Commits on Sep 27, 2022

1. Further simplification of the ZIP publication implementation …

   A follow-up of PR opensearch-project#4156 that brings in further simplification of the ZIP publication implementation and new tests.
   
   It is possible to remove some of the initialization code because the work is already handled by other library under the hood (most likely by NebulaPublishPlugin).
   
   For instance the condition to test the `groupId` presence: `if (groupId == null)` was pointless. It was never `true`. If the `project.group` is not defined the publication task fails with an exception, if there is a custom `groupId` value setup in publication config then it overrides the `project.group` as well. Tests are provided to cover these use cases.
   
   As for the new tests they cover the following cases:
   
   - verify that the task "publishToMavenLocal" gets expected results. The inspiration for this comes from opensearch-project/opensearch-plugin-template-java#35
   
   - verify that applying only the 'opensearch.pluginzip' is enough, because both the NebulaPublish and MavenPublishPlugin plugins are added explicitly and tasks are chained correctly
   
   - verify that if the plugin is applied but no publication is defined then a message is printed for the user
   
   Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io>

   

   lukas-vlcek committed Sep 27, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for 0f9c4cb
   • Browse repository at this point

   Copy the full SHA

   0f9c4cb View commit details

   Browse the repository at this point in the history