Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Change the version to remove deprecated code of adding node name into log pattern of log4j property file #4569

Merged

Conversation

tlfeng
Copy link
Collaborator

@tlfeng tlfeng commented Sep 22, 2022

Description

A following PR of #4568, please see detailed description there.

The part of code is introduced by elastic/elasticsearch@2245957.
The main purpose of the commit is to make the node name available to all loggers all the time, aims make the way of getting logger unified and simple.

There is temporary code added to help users migrate to the new usage of getting node name in log, by scanning the specific pattern setting in log4j.properties files and add the node name into the pattern. A warning message is also added to notify the removal of the temporary code.

  • Change the version number to 3.0 from 7.0 that shown in the warning message.

Issues Resolved

Related to #4274

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Tianli Feng added 2 commits September 21, 2022 23:28
… log pattern of log4j property file

Signed-off-by: Tianli Feng <ftianli@amazon.com>
Signed-off-by: Tianli Feng <ftianli@amazon.com>
@tlfeng tlfeng added deprecate backport 2.3 Backports to 2.3 branch v2.4.0 'Issues and PRs related to version v2.4.0' labels Sep 22, 2022
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

Codecov Report

Merging #4569 (dfeb4cd) into 2.x (3909012) will increase coverage by 0.14%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                2.x    #4569      +/-   ##
============================================
+ Coverage     70.62%   70.76%   +0.14%     
- Complexity    57085    57200     +115     
============================================
  Files          4585     4585              
  Lines        274514   274514              
  Branches      40229    40229              
============================================
+ Hits         193866   194259     +393     
+ Misses        64414    64022     -392     
+ Partials      16234    16233       -1     
Impacted Files Coverage Δ
...org/opensearch/common/logging/LogConfigurator.java 18.27% <ø> (ø)
...regations/metrics/AbstractHyperLogLogPlusPlus.java 51.72% <0.00%> (-44.83%) ⬇️
...pensearch/indices/breaker/CircuitBreakerStats.java 27.77% <0.00%> (-41.67%) ⬇️
...pensearch/action/ingest/DeletePipelineRequest.java 31.25% <0.00%> (-37.50%) ⬇️
...search/search/aggregations/pipeline/EwmaModel.java 24.44% <0.00%> (-33.34%) ⬇️
...arch/search/aggregations/pipeline/SimpleModel.java 38.46% <0.00%> (-30.77%) ⬇️
...opensearch/index/reindex/BulkByScrollResponse.java 48.38% <0.00%> (-29.04%) ⬇️
.../opensearch/index/reindex/ScrollableHitSource.java 69.02% <0.00%> (-23.90%) ⬇️
.../opensearch/client/indices/GetMappingsRequest.java 58.82% <0.00%> (-23.53%) ⬇️
...c/main/java/org/opensearch/geometry/MultiLine.java 80.00% <0.00%> (-20.00%) ⬇️
... and 493 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tlfeng tlfeng marked this pull request as ready for review September 22, 2022 17:30
@tlfeng tlfeng requested review from a team and reta as code owners September 22, 2022 17:30
@tlfeng tlfeng removed the backport 2.3 Backports to 2.3 branch label Sep 22, 2022
@tlfeng
Copy link
Collaborator Author

tlfeng commented Sep 22, 2022

@andrross Thank you for your review! 👍

@tlfeng tlfeng added the backport 2.3 Backports to 2.3 branch label Sep 22, 2022
@tlfeng tlfeng merged commit 83b0ba1 into opensearch-project:2.x Sep 22, 2022
@tlfeng tlfeng deleted the 2.x-change-log-node-name-remove-version branch September 22, 2022 21:06
@tlfeng tlfeng restored the 2.x-change-log-node-name-remove-version branch September 22, 2022 21:06
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 22, 2022
…e into log pattern of log4j property file (#4569)

Signed-off-by: Tianli Feng <ftianli@amazon.com>
(cherry picked from commit 83b0ba1)
@tlfeng tlfeng deleted the 2.x-change-log-node-name-remove-version branch September 22, 2022 21:07
tlfeng pushed a commit that referenced this pull request Sep 22, 2022
…e into log pattern of log4j property file (#4569) (#4574)

Signed-off-by: Tianli Feng <ftianli@amazon.com>
(cherry picked from commit 83b0ba1)
@tlfeng tlfeng linked an issue Sep 24, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.3 Backports to 2.3 branch deprecate v2.4.0 'Issues and PRs related to version v2.4.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] legacy code in LogConfigurator
3 participants