Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix day of year defaulting for round up parser #4621

Closed

Conversation

Vishalks
Copy link
Contributor

Description

This change fixes the conflict gets when trying to round up input date ranges, specifically for the format "yyyy-DDD'T'HH:mm:ss.SSS". For this input format, we default day of year to 1 else default month of year and day of month to 1

Issues Resolved

#4285

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Vishalks Vishalks requested review from a team and reta as code owners September 28, 2022 19:34
@dreamer-89
Copy link
Member

dreamer-89 commented Sep 28, 2022

@Vishalks : You need to sign off the commits without which DCO check will fail. I think you can squash your commits into one and add -s flag for signoff. You can check more about DCO check here

Similarly, you can follow changelog guide here to fix changelog verifier.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Vishalks and others added 19 commits September 28, 2022 13:46
Signed-off-by: Vishal Sarda <vsarda@amazon.com>
…og enabled indices (opensearch-project#4318)

Signed-off-by: Ashish Singh <ssashish@amazon.com>
Signed-off-by: Vishal Sarda <vsarda@amazon.com>
opensearch-project#4241)

* Weighted round-robin scheduling policy for shard coordination traffic routing

Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
Signed-off-by: Vishal Sarda <vsarda@amazon.com>
…h-project#4540)

* Add javadocs for example-plugins:custom-settings module

Signed-off-by: Daniel Widdis <widdis@gmail.com>

* Add javadocs for example-plugins:custom-significance-heuristic

Signed-off-by: Daniel Widdis <widdis@gmail.com>

* Add javadocs for example-plugins:custom-suggester

Signed-off-by: Daniel Widdis <widdis@gmail.com>

* Add javadocs to example-plugins:painless-allowlist

Signed-off-by: Daniel Widdis <widdis@gmail.com>

* Add javadocs to example-plugins:rescore

Signed-off-by: Daniel Widdis <widdis@gmail.com>

* Add javadocs to example-plugins:rest-handler

Signed-off-by: Daniel Widdis <widdis@gmail.com>

* Add javadocs to example-plugins:script-expert-scoring

Signed-off-by: Daniel Widdis <widdis@gmail.com>

* Remove exclusions for module which aren't giving javadoc errors

Signed-off-by: Daniel Widdis <widdis@gmail.com>

* CI testing apparently needs to instantiate a no-op class

Signed-off-by: Daniel Widdis <widdis@gmail.com>

Signed-off-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: Vishal Sarda <vsarda@amazon.com>
…3980) (opensearch-project#4266)

Enables geo_bounds aggregation to work with geo_shape field types.

This enhancement includes:
    * Addition of Doc values on the GeoShape Field.
    * Addition of GeoShape ValueSource level code interfaces for accessing the DocValues.
    * Addition of Missing Value feature in the GeoShape Aggregations.

Signed-off-by: Navneet Verma <navneev@amazon.com>
Signed-off-by: Vishal Sarda <vsarda@amazon.com>
* Upgrade jackson and snakeyml dependencies

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>

* Updated changelog

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Signed-off-by: Vishal Sarda <vsarda@amazon.com>
…4547)

* Bump com.diffplug.spotless from 6.10.0 to 6.11.0

---
updated-dependencies:
- dependency-name: com.diffplug.spotless
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Vishal Sarda <vsarda@amazon.com>
…pensearch-project#4548)

* Bump reactor-core from 3.4.18 to 3.4.23 in /plugins/repository-azure

Bumps [reactor-core](https://github.com/reactor/reactor-core) from 3.4.18 to 3.4.23.
- [Release notes](https://github.com/reactor/reactor-core/releases)
- [Commits](reactor/reactor-core@v3.4.18...v3.4.23)

---
updated-dependencies:
- dependency-name: io.projectreactor:reactor-core
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Vishal Sarda <vsarda@amazon.com>
…nsearch-project#4550)

* Bump jempbox from 1.8.16 to 1.8.17 in /plugins/ingest-attachment

Bumps jempbox from 1.8.16 to 1.8.17.

---
updated-dependencies:
- dependency-name: org.apache.pdfbox:jempbox
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Vishal Sarda <vsarda@amazon.com>
…artyAudit (opensearch-project#4549)

* Bump log4j-core in /buildSrc/src/testKit/thirdPartyAudit

Bumps log4j-core from 2.18.0 to 2.19.0.

---
updated-dependencies:
- dependency-name: org.apache.logging.log4j:log4j-core
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update changelog

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Signed-off-by: Vishal Sarda <vsarda@amazon.com>
…ensearch-project#4544)

Signed-off-by: Daniel Widdis <widdis@gmail.com>

Signed-off-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: Vishal Sarda <vsarda@amazon.com>
…perty file (opensearch-project#4568)

Signed-off-by: Tianli Feng <ftianli@amazon.com>
Signed-off-by: Vishal Sarda <vsarda@amazon.com>
This reverts commit 37fc8aa.

Signed-off-by: Vishal Sarda <vsarda@amazon.com>
…oject#4580)

Signed-off-by: Marc Handalian <handalm@amazon.com>

Signed-off-by: Marc Handalian <handalm@amazon.com>
Signed-off-by: Vishal Sarda <vsarda@amazon.com>
…ommissioning (opensearch-project#4084)

* Add Executor to decommission node attribute
* Decommission service implementation with cluster metadata
* Master abdication changes to decommission local awareness leader
* Update join validator changes to validate decommissioned node join request

Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
Signed-off-by: Vishal Sarda <vsarda@amazon.com>
…ch-project#4388)

* Changes for list all and pit segments

Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
Signed-off-by: Vishal Sarda <vsarda@amazon.com>
* Add PUT api to update shard routing weights

Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
Signed-off-by: Vishal Sarda <vsarda@amazon.com>
…rch-project#4360)

A follow-up of PR opensearch-project#4156 that brings in further simplification of the ZIP publication implementation and new tests.

It is possible to remove some of the initialization code because the work is already handled by other library under the hood (most likely by NebulaPublishPlugin).

For instance the condition to test the `groupId` presence: `if (groupId == null)` was pointless. It was never `true`. If the `project.group` is not defined the publication task fails with an exception, if there is a custom `groupId` value setup in publication config then it overrides the `project.group` as well. Tests are provided to cover these use cases.

As for the new tests they cover the following cases:

- verify that the task "publishToMavenLocal" gets expected results. The inspiration for this comes from opensearch-project/opensearch-plugin-template-java#35

- verify that applying only the 'opensearch.pluginzip' is enough, because both the NebulaPublish and MavenPublishPlugin plugins are added explicitly and tasks are chained correctly

- verify that if the plugin is applied but no publication is defined then a message is printed for the user

Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io>

Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io>
Signed-off-by: Vishal Sarda <vsarda@amazon.com>
Signed-off-by: Vishal Sarda <vsarda@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.