Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix weighted routing metadata deserialization error during node restart #4691

Merged

Conversation

anshu1106
Copy link
Contributor

@anshu1106 anshu1106 commented Oct 6, 2022

Signed-off-by: Anshu Agarwal anshukag@amazon.com

Description

Deserialization of weighted routing metadata is failing during node restart. This PR fixes the serialization error

Issues Resolved

#4690

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
@anshu1106 anshu1106 requested review from a team and reta as code owners October 6, 2022 07:34
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2022

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2022

Gradle Check (Jenkins) Run Completed with:

Copy link
Collaborator

@Bukhtawar Bukhtawar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please lets add tests here

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2022

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2022

Gradle Check (Jenkins) Run Completed with:

Copy link
Member

@imRishN imRishN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @anshu1106

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2022

Gradle Check (Jenkins) Run Completed with:

@anshu1106
Copy link
Contributor Author

Gradle Check (Jenkins) Run Completed with:

Build is unstable due to unrelated test failures. Building again

[Test Result](https://build.ci.opensearch.org/job/gradle-check/4100/testReport/) (3 failures / +3)
[org.opensearch.action.admin.indices.create.CreateIndexIT.testCreateAndDeleteIndexConcurrently](https://build.ci.opensearch.org/job/gradle-check/4100/testReport/junit/org.opensearch.action.admin.indices.create/CreateIndexIT/testCreateAndDeleteIndexConcurrently/)
[org.opensearch.action.admin.indices.create.CreateIndexIT.classMethod](https://build.ci.opensearch.org/job/gradle-check/4100/testReport/junit/org.opensearch.action.admin.indices.create/CreateIndexIT/classMethod/)
[org.opensearch.indices.stats.IndexStatsIT.testFilterCacheStats](https://build.ci.opensearch.org/job/gradle-check/4100/testReport/junit/org.opensearch.indices.stats/IndexStatsIT/testFilterCacheStats/)

Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
@anshu1106 anshu1106 force-pushed the bug/weighted-routing-metadata branch from 636afab to cc83386 Compare October 7, 2022 06:47
@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2022

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2022

Codecov Report

Merging #4691 (5b6d792) into main (7c03f89) will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #4691      +/-   ##
============================================
+ Coverage     70.71%   70.73%   +0.02%     
- Complexity    57569    57599      +30     
============================================
  Files          4660     4660              
  Lines        276601   276600       -1     
  Branches      40307    40307              
============================================
+ Hits         195596   195660      +64     
+ Misses        64771    64696      -75     
- Partials      16234    16244      +10     
Impacted Files Coverage Δ
...arch/cluster/metadata/WeightedRoutingMetadata.java 61.40% <ø> (+1.05%) ⬆️
...search/indices/recovery/RecoveryTargetHandler.java 0.00% <0.00%> (-100.00%) ⬇️
.../java/org/opensearch/node/NodeClosedException.java 50.00% <0.00%> (-50.00%) ⬇️
.../index/shard/IndexShardNotRecoveringException.java 50.00% <0.00%> (-50.00%) ⬇️
.../admin/cluster/reroute/ClusterRerouteResponse.java 60.00% <0.00%> (-40.00%) ⬇️
...luster/routing/allocation/RoutingExplanations.java 62.06% <0.00%> (-37.94%) ⬇️
...java/org/opensearch/threadpool/ThreadPoolInfo.java 56.25% <0.00%> (-37.50%) ⬇️
...ensearch/client/indices/DetailAnalyzeResponse.java 20.54% <0.00%> (-34.25%) ⬇️
...cluster/routing/allocation/RerouteExplanation.java 70.00% <0.00%> (-30.00%) ⬇️
...org/opensearch/test/engine/MockInternalEngine.java 56.52% <0.00%> (-26.09%) ⬇️
... and 488 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@nknize nknize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@Bukhtawar Bukhtawar merged commit d15795a into opensearch-project:main Oct 12, 2022
anshu1106 added a commit to anshu1106/OpenSearch that referenced this pull request Nov 1, 2022
…rt (opensearch-project#4691)

* Fix weighted routing metadata deserialization error during node restart

Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
@anshu1106 anshu1106 mentioned this pull request Nov 1, 2022
6 tasks
anshu1106 added a commit to anshu1106/OpenSearch that referenced this pull request Nov 3, 2022
…rt (opensearch-project#4691)

* Fix weighted routing metadata deserialization error during node restart

Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
Bukhtawar pushed a commit that referenced this pull request Nov 3, 2022
* Weighted round-robin scheduling policy for shard coordination traffic… (#4241)

* Add PUT api to update shard routing weights (#4272)

* Add GET api to get shard routing weights (#4275)

* Fix weighted routing metadata deserialization error during node restart (#4691)

* Delete API for weighted round robin search routing (#4400)

* Mark apis experimental

Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
Bukhtawar pushed a commit that referenced this pull request Nov 3, 2022
* Weighted round-robin scheduling policy for shard coordination traffic… (#4241)

* Add PUT api to update shard routing weights (#4272)

* Add GET api to get shard routing weights (#4275)

* Fix weighted routing metadata deserialization error during node restart (#4691)

* Delete API for weighted round robin search routing (#4917 

* Mark apis experimental

Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
ashking94 pushed a commit to ashking94/OpenSearch that referenced this pull request Nov 7, 2022
…rt (opensearch-project#4691)

* Fix weighted routing metadata deserialization error during node restart

Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants