Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Deprecate] RepositoryData.MIN_VERSION for removal in next major release #4729

Merged
merged 2 commits into from
Oct 11, 2022
Merged

[Deprecate] RepositoryData.MIN_VERSION for removal in next major release #4729

merged 2 commits into from
Oct 11, 2022

Conversation

nknize
Copy link
Collaborator

@nknize nknize commented Oct 10, 2022

This min_version field in the RepositoryData metadata is only used for ancient snapshot generations
and needs to be removed in the next major version. This commit sets up the removal for backwards
compatibility support.

@nknize
[Deprecate] RepositoryData.MIN_VERSION
2b9495e 
This field is only used for old snapshot generations and needs to be removed in
the next major version. This commit sets up the removal for backwards
compatibility support.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@nknize nknize added non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues deprecate v2.4.0 'Issues and PRs related to version v2.4.0' labels Oct 10, 2022
@nknize nknize requested review from a team and reta as code owners October 10, 2022 20:52
@nknize
update changelog
0eb40a3 
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@nknize nknize mentioned this pull request Oct 10, 2022
Merged
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@nknize
Copy link
Collaborator Author

nknize commented Oct 11, 2022

This needs to merge before we can continue removing Legacy versions.

@nknize nknize merged commit 9feddc1 into opensearch-project:2.x Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamer-89 dreamer-89 dreamer-89 approved these changes

@reta reta Awaiting requested review from reta reta is a code owner

Assignees
No one assigned
Labels
deprecate non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues v2.4.0 'Issues and PRs related to version v2.4.0'
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nknize @dreamer-89