Changed http code on create index API with bad input raising NotXContentException to 400 #4773

ayushKataria · 2022-10-13T14:36:57Z

Description

[Describe what this change achieves]
Changed http code on create index API with bad input raising NotXContentException to 400

Issues Resolved

[List any issues this PR will resolve]
#2756

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff
Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions · 2022-10-13T15:05:18Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/4590/
CommitID: bf0ba03

github-actions · 2022-10-13T15:09:43Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/4591/
CommitID: 618e8aa

github-actions · 2022-10-14T03:49:30Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/4675/
CommitID: a9eed0f

codecov-commenter · 2022-10-14T03:51:33Z

Codecov Report

Merging #4773 (ba6c39f) into main (bdb8efe) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #4773      +/-   ##
============================================
+ Coverage     70.86%   70.88%   +0.02%     
- Complexity    58068    58081      +13     
============================================
  Files          4710     4710              
  Lines        277508   277510       +2     
  Branches      40164    40165       +1     
============================================
+ Hits         196661   196725      +64     
+ Misses        64663    64630      -33     
+ Partials      16184    16155      -29

Impacted Files	Coverage Δ
...src/main/java/org/opensearch/ExceptionsHelper.java	`83.87% <100.00%> (+3.47%)`	⬆️
.../action/admin/indices/flush/ShardFlushRequest.java	`50.00% <0.00%> (-50.00%)`	⬇️
...h/aggregations/bucket/terms/ParsedDoubleTerms.java	`39.13% <0.00%> (-47.83%)`	⬇️
...pensearch/indices/breaker/CircuitBreakerStats.java	`27.77% <0.00%> (-41.67%)`	⬇️
.../admin/cluster/reroute/ClusterRerouteResponse.java	`60.00% <0.00%> (-40.00%)`	⬇️
...h/action/ingest/SimulateDocumentVerboseResult.java	`60.71% <0.00%> (-39.29%)`	⬇️
...luster/routing/allocation/RoutingExplanations.java	`62.06% <0.00%> (-37.94%)`	⬇️
...java/org/opensearch/threadpool/ThreadPoolInfo.java	`56.25% <0.00%> (-37.50%)`	⬇️
...pensearch/action/ingest/DeletePipelineRequest.java	`31.25% <0.00%> (-37.50%)`	⬇️
...earch/action/admin/indices/flush/FlushRequest.java	`52.17% <0.00%> (-34.79%)`	⬇️
... and 489 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

github-actions · 2022-10-20T08:00:44Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/5032/
CommitID: e952cb9

dblock

This needs a test, please.

CHANGELOG.md

github-actions · 2022-10-21T06:39:52Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/5148/
CommitID: 41f1e5f

github-actions · 2022-10-21T09:46:34Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/5162/
CommitID: 9fcb009

github-actions · 2022-10-21T10:25:12Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/5166/
CommitID: 577894b

ayushKataria · 2022-10-21T10:26:51Z

@dblock Added the test as suggested. Not sure what the tests failing are. Can you help with this?

CHANGELOG.md

dblock · 2022-10-21T16:15:33Z

I wrote a quick guide to how to deal with flakey tests in #4868 (bottom of dev guide) - care to try it for me?

github-actions · 2022-10-21T20:51:38Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/5234/
CommitID: 577894b

mch2

Thanks for taking this @ayushKataria.

mch2 · 2022-10-21T21:53:55Z

Retriggered check - unrelated failure.

REPRODUCE WITH: ./gradlew ':server:test' --tests "org.opensearch.index.shard.SegmentReplicationIndexShardTests.testReplicaReceivesLowerGeneration" -Dtests.seed=25A1BC6ABB78D54B -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=hu -Dtests.timezone=Australia/Darwin -Druntime.java=17

org.opensearch.index.shard.SegmentReplicationIndexShardTests > testReplicaReceivesLowerGeneration FAILED
    java.lang.AssertionError
        at __randomizedtesting.SeedInfo.seed([25A1BC6ABB78D54B:AACF30236089C3AF]:0)
        at org.junit.Assert.fail(Assert.java:87)
        at org.junit.Assert.assertTrue(Assert.java:42)
        at org.junit.Assert.assertTrue(Assert.java:53)
        at org.opensearch.index.shard.SegmentReplicationIndexShardTests.assertEqualCommittedSegments(SegmentReplicationIndexShardTests.java:717)
        at org.opensearch.index.shard.SegmentReplicationIndexShardTests.testReplicaReceivesLowerGeneration(SegmentReplicationIndexShardTests.java:306)

github-actions · 2022-10-21T22:25:16Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/5277/
CommitID: 577894b

github-actions · 2022-10-22T05:27:54Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ❌
URL: https://build.ci.opensearch.org/job/gradle-check/5303/
CommitID: 447714a

github-actions · 2022-10-24T14:20:24Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/5358/
CommitID: 447714a

github-actions · 2022-11-03T00:48:59Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/6273/
CommitID: 447714a

dblock · 2022-11-07T19:01:12Z

@ayushKataria rebase this? lets see if the tests are still flaky, then just work through them

github-actions · 2022-11-08T04:23:24Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/6499/
CommitID: 528ebf6
Please examine the workflow log, locate, and copy-paste the failure below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2022-11-08T05:03:51Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/6517/
CommitID: e8a8825
Please examine the workflow log, locate, and copy-paste the failure below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2022-11-14T07:59:15Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/6852/
CommitID: b69c524

ayushKataria · 2022-11-14T10:23:16Z

@dblock I was seeing some build errors earlier, but when I synced this today it has gone through successfully.

dblock

See below for CHANGELOG:

CHANGELOG.md

github-actions · 2022-11-15T05:51:52Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/6884/
CommitID: 4e6b953

github-actions · 2022-11-15T05:57:56Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/6885/
CommitID: 00f5101

dblock · 2022-11-15T14:01:11Z

DCO and precommit are failing :( back to you @ayushKataria lmk if you need help (I recommend you squash these commits on your local and sign the 1 commit left with git commit -s).

github-actions · 2022-11-19T17:41:11Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/7113/
CommitID: 1da8fdd
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

dblock · 2022-11-21T19:52:14Z

@ayushKataria do you need help with DCO or the gradle checks above?

ayushKataria · 2022-11-22T08:21:30Z

@dblock Yes, I would appreciate some help with this. What happened is that for the change in CHANGELOG, I was travelling so I pushed from a different machine but missed the sign off on that. I tried squashing the commits, but since I have merged from upstream, it says "has 2 parents", so, I am not able to squash and push with a single signed off commit. What would you suggest I should do now?

For the gradle check, I am not sure what the issue is. It seems to be failing at a build stage and not a test failure. This is the task it seems to be failing at

Execution failed for task ':distribution:bwc:staged:buildBwcLinuxTar'.
> Building 2.4.0 didn't generate expected file /var/jenkins/workspace/gradle-check/search/distribution/bwc/staged/build/bwc/checkout-2.4/distribution/archives/linux-tar/build/distributions/opensearch-min-2.4.0-SNAPSHOT-linux-x64.tar.gz

dblock · 2022-11-22T17:58:01Z

I think the easiest is to do a subset of https://code.dblock.org/2015/08/31/getting-out-of-your-first-git-mess.html, ie. create a new clean branch, merge your changes onto it, then force push that clean slate to the xcontentstatuscode branch on GitHub to update this PR.

git checkout main 
git pull upstream main 
git checkout -b xcontentstatuscode-squashed 
git merge xcontentstatuscode --squash
# examine the diff, ensure it's all nice and clean, resolve any conflicts, edit CHANGELOG
git add .
git commit -s -m "...."
git push origin xcontentstatuscode-squashed:xcontentstatuscode -f

…ash for DCO fix Signed-off-by: Ayush Kataria <31301636+ayushKataria@users.noreply.github.com>

github-actions · 2022-11-23T10:39:15Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/7268/
CommitID: ba6c39f

ayushKataria · 2022-11-23T10:54:14Z

@dblock Thanks, it's gone through now. I am going to save that link for future references.

dblock · 2022-11-23T16:25:29Z

Thanks for hanging in here with us @ayushKataria! Merged.

@CEHENKLE @andrross We don't backport this one to 2.x or do we? :)

ayushKataria requested review from a team and reta as code owners October 13, 2022 14:36

ayushKataria mentioned this pull request Oct 20, 2022

[BUG] Wrong http code returned from create index API with bad input. #2756

Closed

dblock requested changes Oct 20, 2022

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

dblock approved these changes Oct 21, 2022

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

mch2 approved these changes Oct 21, 2022

View reviewed changes

dblock requested changes Nov 14, 2022

View reviewed changes

CHANGELOG.md Show resolved Hide resolved

dblock approved these changes Nov 15, 2022

View reviewed changes

NotXContentException status code changed from 500 to 400 - commit squ…

ba6c39f

…ash for DCO fix Signed-off-by: Ayush Kataria <31301636+ayushKataria@users.noreply.github.com>

ayushKataria force-pushed the xcontentstatuscode branch from 1da8fdd to ba6c39f Compare November 23, 2022 10:08

dblock approved these changes Nov 23, 2022

View reviewed changes

dblock merged commit 139c2cf into opensearch-project:main Nov 23, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Changed http code on create index API with bad input raising NotXContentException to 400 #4773

Changed http code on create index API with bad input raising NotXContentException to 400 #4773

ayushKataria commented Oct 13, 2022 •

edited

Loading

github-actions bot commented Oct 13, 2022

github-actions bot commented Oct 13, 2022

github-actions bot commented Oct 14, 2022

codecov-commenter commented Oct 14, 2022 •

edited

Loading

github-actions bot commented Oct 20, 2022

dblock left a comment

github-actions bot commented Oct 21, 2022

github-actions bot commented Oct 21, 2022

github-actions bot commented Oct 21, 2022

ayushKataria commented Oct 21, 2022

dblock commented Oct 21, 2022 •

edited

Loading

github-actions bot commented Oct 21, 2022

mch2 left a comment

mch2 commented Oct 21, 2022

github-actions bot commented Oct 21, 2022

github-actions bot commented Oct 22, 2022

github-actions bot commented Oct 24, 2022

github-actions bot commented Nov 3, 2022

dblock commented Nov 7, 2022

github-actions bot commented Nov 8, 2022

github-actions bot commented Nov 8, 2022

github-actions bot commented Nov 14, 2022

ayushKataria commented Nov 14, 2022 •

edited

Loading

dblock left a comment

github-actions bot commented Nov 15, 2022

github-actions bot commented Nov 15, 2022

dblock commented Nov 15, 2022

github-actions bot commented Nov 19, 2022

dblock commented Nov 21, 2022 •

edited

Loading

ayushKataria commented Nov 22, 2022 •

edited

Loading

dblock commented Nov 22, 2022 •

edited

Loading

github-actions bot commented Nov 23, 2022

ayushKataria commented Nov 23, 2022 •

edited

Loading

dblock commented Nov 23, 2022

Changed http code on create index API with bad input raising NotXContentException to 400 #4773

Changed http code on create index API with bad input raising NotXContentException to 400 #4773

Conversation

ayushKataria commented Oct 13, 2022 • edited Loading

Description

Issues Resolved

Check List

github-actions bot commented Oct 13, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Oct 13, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Oct 14, 2022

Gradle Check (Jenkins) Run Completed with:

codecov-commenter commented Oct 14, 2022 • edited Loading

Codecov Report

github-actions bot commented Oct 20, 2022

Gradle Check (Jenkins) Run Completed with:

dblock left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 21, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Oct 21, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Oct 21, 2022

Gradle Check (Jenkins) Run Completed with:

ayushKataria commented Oct 21, 2022

dblock commented Oct 21, 2022 • edited Loading

github-actions bot commented Oct 21, 2022

Gradle Check (Jenkins) Run Completed with:

mch2 left a comment

Choose a reason for hiding this comment

mch2 commented Oct 21, 2022

github-actions bot commented Oct 21, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Oct 22, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Oct 24, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Nov 3, 2022

Gradle Check (Jenkins) Run Completed with:

dblock commented Nov 7, 2022

github-actions bot commented Nov 8, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Nov 8, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Nov 14, 2022

Gradle Check (Jenkins) Run Completed with:

ayushKataria commented Nov 14, 2022 • edited Loading

dblock left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 15, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Nov 15, 2022

Gradle Check (Jenkins) Run Completed with:

dblock commented Nov 15, 2022

github-actions bot commented Nov 19, 2022

Gradle Check (Jenkins) Run Completed with:

dblock commented Nov 21, 2022 • edited Loading

ayushKataria commented Nov 22, 2022 • edited Loading

dblock commented Nov 22, 2022 • edited Loading

github-actions bot commented Nov 23, 2022

Gradle Check (Jenkins) Run Completed with:

ayushKataria commented Nov 23, 2022 • edited Loading

dblock commented Nov 23, 2022

ayushKataria commented Oct 13, 2022 •

edited

Loading

codecov-commenter commented Oct 14, 2022 •

edited

Loading

dblock commented Oct 21, 2022 •

edited

Loading

ayushKataria commented Nov 14, 2022 •

edited

Loading

dblock commented Nov 21, 2022 •

edited

Loading

ayushKataria commented Nov 22, 2022 •

edited

Loading

dblock commented Nov 22, 2022 •

edited

Loading

ayushKataria commented Nov 23, 2022 •

edited

Loading