[Backport 2.x]Support of GeoJson Point for GeoPoint field (#4597) #4842

heemin32 · 2022-10-19T18:54:17Z

Support of GeoJson Point for GeoPoint field

Signed-off-by: Heemin Kim heemin@amazon.com
(cherry picked from commit a282d39)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions · 2022-10-19T19:32:09Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/4992/
CommitID: 1a1d1c5

github-actions · 2022-10-19T22:36:00Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/5005/
CommitID: 1a1d1c5

github-actions · 2022-10-19T23:33:38Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/5012/
CommitID: 86fd99e

github-actions · 2022-10-19T23:43:09Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/5011/
CommitID: 6fd8fe5

github-actions · 2022-10-20T00:03:17Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/5015/
CommitID: 86fd99e

github-actions · 2022-10-20T01:24:05Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/5017/
CommitID: 2786f7b

heemin32 · 2022-10-20T01:29:44Z

All unrelated test failures.

heemin32 · 2022-10-20T01:30:34Z

@dblock Please take a look and merge it.

dblock · 2022-10-20T18:40:17Z

@dblock Please take a look and merge it.

Please take a look at these unrelated failures, and for each locate whether it's intermittent and whether there's an issue already opened, and link the PR to it - we keep count so we can address issues in priority order. Please open new issues for any new intermittent failures. You can then force push on your branch to retry CI till it's green. Unfortunately flakey tests are what we live with rn :(

heemin32 · 2022-10-20T18:45:05Z

Failure of org.opensearch.search.PitMultiNodeTests.testCreatePitWhileNodeDropWithAllowPartialCreationFalse is from #4259

github-actions · 2022-10-20T19:08:15Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/5086/
CommitID: 2786f7b

heemin32 · 2022-10-20T19:25:34Z

Failing test is from #4859

github-actions · 2022-10-20T19:57:56Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/5101/
CommitID: 2786f7b

heemin32 · 2022-10-20T20:50:19Z

#4831 & #4861

github-actions · 2022-10-20T21:25:52Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/5114/
CommitID: a8ec925

dblock · 2022-10-20T21:35:42Z

Tests with failures:
 - org.opensearch.index.fielddata.SortedSetDVStringFieldDataTests.testSortMissingLast
 - org.opensearch.index.fielddata.SortedSetDVStringFieldDataTests.testSortMissingLastReverse
 -

@heemin32 This is not a fluke isn't it? I didn't try

heemin32 · 2022-10-20T21:49:02Z

Tests with failures:
 - org.opensearch.index.fielddata.SortedSetDVStringFieldDataTests.testSortMissingLast
 - org.opensearch.index.fielddata.SortedSetDVStringFieldDataTests.testSortMissingLastReverse
 -

@heemin32 This is not a fluke isn't it? I didn't try

Those are flaky tests. The tests passed in local when tried several times.
#4861

heemin32 · 2022-10-20T22:07:24Z

@dblock We should merge this PR to 2.x branch. #4270

dblock · 2022-10-21T15:47:01Z

I backported #4270 in #4867, rebase?

github-actions · 2022-10-21T16:44:43Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/5183/
CommitID: 4b82a6f

dblock · 2022-10-21T16:52:02Z

I added a section in dev guide on what to do with flakey tests, care to try it out for me @heemin32?
#4868

heemin32 · 2022-10-21T17:41:35Z

[Test Result](https://build.ci.opensearch.org/job/gradle-check/5183/testReport/) (4 failures / -4)
[org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=search/190_index_prefix_search/search with uppercase regex}](https://build.ci.opensearch.org/job/gradle-check/5183/testReport/junit/org.opensearch.backwards/MixedClusterClientYamlTestSuiteIT/test__p0_search_190_index_prefix_search_search_with_uppercase_regex_/)
[org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=search/190_index_prefix_search/search with uppercase regex}](https://build.ci.opensearch.org/job/gradle-check/5183/testReport/junit/org.opensearch.backwards/MixedClusterClientYamlTestSuiteIT/test__p0_search_190_index_prefix_search_search_with_uppercase_regex__2/)
[org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=search/190_index_prefix_search/search with uppercase regex}](https://build.ci.opensearch.org/job/gradle-check/5183/testReport/junit/org.opensearch.backwards/MixedClusterClientYamlTestSuiteIT/test__p0_search_190_index_prefix_search_search_with_uppercase_regex__3/)
[org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=search/190_index_prefix_search/search with uppercase regex}](https://build.ci.opensearch.org/job/gradle-check/5183/testReport/junit/org.opensearch.backwards/MixedClusterClientYamlTestSuiteIT/test__p0_search_190_index_prefix_search_search_with_uppercase_regex__4/)

Existing issue: #4831

heemin32 · 2022-10-21T18:02:43Z

I added a section in dev guide on what to do with flakey tests, care to try it out for me @heemin32? #4868

3. Search through [issues](https://github.com/opensearch-project/OpenSearch/issues?q=is%3Aopen+is%3Aissue+label%3A%22Flakey+Random+Test+Failure%22) using the name of the failed test for whether this is a known flakey test. 
-> Why not just search issue using failed test name as keyword? Some issue might not have been tagged properly yet.
5. If an existing issue is found, paste a link to the known issue in a comment to your PR.
6. If no existing issue is found, open one.
-> If no existing issue is found, open one and paste a link to the issue in a comment to your PR.
8. Retry CI via the GitHub UX or by pushing an update to your PR.
-> Retry CI via the GitHub UX is only available to maintainers.
-> Would be nice state clearly about how many times someone should try. Until everything succeed?

andrross · 2022-10-21T18:46:19Z

@heemin32 can you rebase to pull in #4869?

* Support of GeoJson Point for GeoPoint field See opensearch-project/geospatial#152 Signed-off-by: Heemin Kim <heemin@amazon.com> (cherry picked from commit a282d39)

Signed-off-by: Heemin Kim <heemin@amazon.com>

github-actions · 2022-10-21T19:22:30Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/5222/
CommitID: 77c40db

andrross · 2022-10-21T19:56:17Z

@heemin32 can you fix the changelog conflicts?

github-actions · 2022-10-21T21:41:57Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/5263/
CommitID: 7f31b64

heemin32 · 2022-10-21T21:47:02Z

[Test Result](https://build.ci.opensearch.org/job/gradle-check/5263/testReport/) (4 failures / +4)
[org.opensearch.search.PitMultiNodeTests.testCreatePitWhileNodeDropWithAllowPartialCreationFalse](https://build.ci.opensearch.org/job/gradle-check/5263/testReport/junit/org.opensearch.search/PitMultiNodeTests/testCreatePitWhileNodeDropWithAllowPartialCreationFalse/)
[org.opensearch.search.PitMultiNodeTests.testCreatePitWhileNodeDropWithAllowPartialCreationFalse](https://build.ci.opensearch.org/job/gradle-check/5263/testReport/junit/org.opensearch.search/PitMultiNodeTests/testCreatePitWhileNodeDropWithAllowPartialCreationFalse_2/)
[org.opensearch.search.PitMultiNodeTests.testCreatePitWhileNodeDropWithAllowPartialCreationFalse](https://build.ci.opensearch.org/job/gradle-check/5263/testReport/junit/org.opensearch.search/PitMultiNodeTests/testCreatePitWhileNodeDropWithAllowPartialCreationFalse_3/)
[org.opensearch.search.PitMultiNodeTests.testCreatePitWhileNodeDropWithAllowPartialCreationFalse](https://build.ci.opensearch.org/job/gradle-check/5263/testReport/junit/org.opensearch.search/PitMultiNodeTests/testCreatePitWhileNodeDropWithAllowPartialCreationFalse_4/)

Flaky test: #4259

github-actions · 2022-10-21T22:21:20Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/5275/
CommitID: 7f31b64

github-actions · 2022-10-21T23:24:53Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/5287/
CommitID: 3bf794f

heemin32 requested review from a team and reta as code owners October 19, 2022 18:54

heemin32 changed the title ~~Support of GeoJson Point for GeoPoint field (#4597)~~ [Backport 2.x]Support of GeoJson Point for GeoPoint field (#4597) Oct 19, 2022

heemin32 mentioned this pull request Oct 19, 2022

Support of GeoJson Point for GeoPoint field #4597

Merged

6 tasks

heemin32 closed this Oct 19, 2022

heemin32 reopened this Oct 19, 2022

heemin32 closed this Oct 19, 2022

heemin32 reopened this Oct 19, 2022

heemin32 force-pushed the backport/backport-4597-to-2.x branch from 86fd99e to 2786f7b Compare October 20, 2022 00:58

heemin32 closed this Oct 20, 2022

heemin32 reopened this Oct 20, 2022

heemin32 force-pushed the backport/backport-4597-to-2.x branch from 2786f7b to a8ec925 Compare October 20, 2022 20:51

heemin32 mentioned this pull request Oct 20, 2022

Skip geojson test for version below 2.4 #4860

Merged

6 tasks

heemin32 force-pushed the backport/backport-4597-to-2.x branch from a8ec925 to 4b82a6f Compare October 21, 2022 16:10

heemin32 added 2 commits October 21, 2022 11:48

Support of GeoJson Point for GeoPoint field (opensearch-project#4597)

02b6324

* Support of GeoJson Point for GeoPoint field See opensearch-project/geospatial#152 Signed-off-by: Heemin Kim <heemin@amazon.com> (cherry picked from commit a282d39)

Run geojson yaml test for 2.4 and above only

77c40db

Signed-off-by: Heemin Kim <heemin@amazon.com>

heemin32 force-pushed the backport/backport-4597-to-2.x branch from 4b82a6f to 77c40db Compare October 21, 2022 18:48

Merge branch '2.x' into backport/backport-4597-to-2.x

7f31b64

heemin32 closed this Oct 21, 2022

heemin32 reopened this Oct 21, 2022

Merge branch '2.x' into backport/backport-4597-to-2.x

3bf794f

andrross approved these changes Oct 21, 2022

View reviewed changes

andrross merged commit 0503897 into opensearch-project:2.x Oct 21, 2022

heemin32 deleted the backport/backport-4597-to-2.x branch October 21, 2022 23:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Backport 2.x]Support of GeoJson Point for GeoPoint field (#4597) #4842

[Backport 2.x]Support of GeoJson Point for GeoPoint field (#4597) #4842

heemin32 commented Oct 19, 2022

github-actions bot commented Oct 19, 2022

github-actions bot commented Oct 19, 2022

github-actions bot commented Oct 19, 2022

github-actions bot commented Oct 19, 2022

github-actions bot commented Oct 20, 2022

github-actions bot commented Oct 20, 2022

heemin32 commented Oct 20, 2022

heemin32 commented Oct 20, 2022

dblock commented Oct 20, 2022

heemin32 commented Oct 20, 2022

github-actions bot commented Oct 20, 2022

heemin32 commented Oct 20, 2022

github-actions bot commented Oct 20, 2022

heemin32 commented Oct 20, 2022

github-actions bot commented Oct 20, 2022

dblock commented Oct 20, 2022 •

edited

Loading

heemin32 commented Oct 20, 2022 •

edited

Loading

heemin32 commented Oct 20, 2022 •

edited

Loading

dblock commented Oct 21, 2022

github-actions bot commented Oct 21, 2022

dblock commented Oct 21, 2022 •

edited

Loading

heemin32 commented Oct 21, 2022 •

edited

Loading

heemin32 commented Oct 21, 2022 •

edited

Loading

andrross commented Oct 21, 2022

github-actions bot commented Oct 21, 2022

andrross commented Oct 21, 2022

github-actions bot commented Oct 21, 2022

heemin32 commented Oct 21, 2022

github-actions bot commented Oct 21, 2022

github-actions bot commented Oct 21, 2022

[Backport 2.x]Support of GeoJson Point for GeoPoint field (#4597) #4842

[Backport 2.x]Support of GeoJson Point for GeoPoint field (#4597) #4842

Conversation

heemin32 commented Oct 19, 2022

github-actions bot commented Oct 19, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Oct 19, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Oct 19, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Oct 19, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Oct 20, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Oct 20, 2022

Gradle Check (Jenkins) Run Completed with:

heemin32 commented Oct 20, 2022

heemin32 commented Oct 20, 2022

dblock commented Oct 20, 2022

heemin32 commented Oct 20, 2022

github-actions bot commented Oct 20, 2022

Gradle Check (Jenkins) Run Completed with:

heemin32 commented Oct 20, 2022

github-actions bot commented Oct 20, 2022

Gradle Check (Jenkins) Run Completed with:

heemin32 commented Oct 20, 2022

github-actions bot commented Oct 20, 2022

Gradle Check (Jenkins) Run Completed with:

dblock commented Oct 20, 2022 • edited Loading

heemin32 commented Oct 20, 2022 • edited Loading

heemin32 commented Oct 20, 2022 • edited Loading

dblock commented Oct 21, 2022

github-actions bot commented Oct 21, 2022

Gradle Check (Jenkins) Run Completed with:

dblock commented Oct 21, 2022 • edited Loading

heemin32 commented Oct 21, 2022 • edited Loading

heemin32 commented Oct 21, 2022 • edited Loading

andrross commented Oct 21, 2022

github-actions bot commented Oct 21, 2022

Gradle Check (Jenkins) Run Completed with:

andrross commented Oct 21, 2022

github-actions bot commented Oct 21, 2022

Gradle Check (Jenkins) Run Completed with:

heemin32 commented Oct 21, 2022

github-actions bot commented Oct 21, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Oct 21, 2022

Gradle Check (Jenkins) Run Completed with:

dblock commented Oct 20, 2022 •

edited

Loading

heemin32 commented Oct 20, 2022 •

edited

Loading

heemin32 commented Oct 20, 2022 •

edited

Loading

dblock commented Oct 21, 2022 •

edited

Loading

heemin32 commented Oct 21, 2022 •

edited

Loading

heemin32 commented Oct 21, 2022 •

edited

Loading