Update GeoGrid base class access modifier to support extensibility #4921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VijayanB
force-pushed
the
update-access-modifier
branch
from
8910f93
to
0c79864
Compare
Gradle Check (Jenkins) Run Completed with:
|
|
This PR contains part of changes from #4572 . Since the above PR includes refactoring, created new PR that only contains access modifier change that will help release geohex aggregation in 2.x. |
Gradle Check (Jenkins) Run Completed with:
|
VijayanB
force-pushed
the
update-access-modifier
branch
from
0c79864
to
1e1cba5
Compare
Gradle Check (Jenkins) Run Completed with:
|
|
@dblock Can you take a look at this? Also, gradle check failed due to timeout. i couldn't find an action to retry. can you help me to trigger retry? Thanks |
VijayanB
force-pushed
the
update-access-modifier
branch
from
1e1cba5
to
f0e61fa
Compare
Gradle Check (Jenkins) Run Completed with:
|
Change access modifier from default to protected. This will help to build new geo based aggregation outside OpenSearch, by depending on GeoGrid as base class. Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
VijayanB
force-pushed
the
update-access-modifier
branch
from
f0e61fa
to
9700885
Compare
reta
approved these changes
Oct 25, 2022
Gradle Check (Jenkins) Run Completed with:
|
|
Thanks @reta for review. Can this be merged now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change access modifier from default to protected.
This will help to build new geo based aggregation
outside OpenSearch, by keeping GeoGrid Classes as base class.
Signed-off-by: Vijayan Balasubramanian balasvij@amazon.com
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.