Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delay timeout for decommission request #4931

Merged

Conversation

pranikum
Copy link
Contributor

@pranikum pranikum commented Oct 26, 2022

Signed-off-by: pranikum 109206473+pranikum@users.noreply.github.com

Description

We need to allow delay_timeout to be set as parameter for decommission request

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>
@pranikum pranikum requested review from a team and reta as code owners October 26, 2022 08:08
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2022

Codecov Report

Merging #4931 (b5b2ef0) into main (8c9ca4e) will decrease coverage by 0.47%.
The diff coverage is 71.42%.

@@             Coverage Diff              @@
##               main    #4931      +/-   ##
============================================
- Coverage     71.25%   70.78%   -0.48%     
+ Complexity    58317    57921     -396     
============================================
  Files          4689     4689              
  Lines        277151   277002     -149     
  Branches      40327    40311      -16     
============================================
- Hits         197495   196067    -1428     
- Misses        63658    64682    +1024     
- Partials      15998    16253     +255     
Impacted Files Coverage Δ
...sion/awareness/put/DecommissionRequestBuilder.java 0.00% <0.00%> (ø)
...ecommission/awareness/put/DecommissionRequest.java 92.30% <100.00%> (+12.89%) ⬆️
...t/action/admin/cluster/RestDecommissionAction.java 85.71% <100.00%> (+2.38%) ⬆️
...g/opensearch/index/analysis/CharFilterFactory.java 0.00% <0.00%> (-100.00%) ⬇️
.../java/org/opensearch/node/NodeClosedException.java 50.00% <0.00%> (-50.00%) ⬇️
...cluster/coordination/PendingClusterStateStats.java 20.00% <0.00%> (-48.00%) ⬇️
.../admin/cluster/reroute/ClusterRerouteResponse.java 60.00% <0.00%> (-40.00%) ⬇️
...h/action/ingest/SimulateDocumentVerboseResult.java 60.71% <0.00%> (-39.29%) ⬇️
...luster/routing/allocation/RoutingExplanations.java 62.06% <0.00%> (-37.94%) ⬇️
...cluster/coordination/PublishClusterStateStats.java 33.33% <0.00%> (-37.51%) ⬇️
... and 460 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@Bukhtawar Bukhtawar merged commit 3887b60 into opensearch-project:main Oct 26, 2022
pranikum added a commit to pranikum/OpenSearch that referenced this pull request Nov 3, 2022
* Add delay timeout for decommission request

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>
imRishN pushed a commit to imRishN/OpenSearch that referenced this pull request Nov 3, 2022
* Add delay timeout for decommission request

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
Bukhtawar pushed a commit that referenced this pull request Nov 3, 2022
* Fail weight update when decommission ongoing and fail decommission when attribute not weighed away (#4839)

* Add changes for graceful node decommission (#4586)

* Add delay timeout for decommission request (#4931)

* Integ Tests for Awareness Attribute Decommissioning (#4715)

Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>
imRishN added a commit to imRishN/OpenSearch that referenced this pull request Nov 3, 2022
* Fail weight update when decommission ongoing and fail decommission when attribute not weighed away (opensearch-project#4839)

* Add changes for graceful node decommission (opensearch-project#4586)

* Add delay timeout for decommission request (opensearch-project#4931)

* Integ Tests for Awareness Attribute Decommissioning (opensearch-project#4715)

Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>
ashking94 pushed a commit to ashking94/OpenSearch that referenced this pull request Nov 7, 2022
* Add delay timeout for decommission request

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants