Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing test: VerifyVersionConstantsIT #4946

Merged
merged 2 commits into from
Oct 26, 2022

Conversation

Poojita-Raj
Copy link
Contributor

Signed-off-by: Poojita Raj poojiraj@amazon.com

Description

Fix for failing VerifyVersionConstantsIT tests on gradle check. Caused by lucene version mismatch after lucene version upgrade.

Issues Resolved

Resolves #4945

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Poojita Raj <poojiraj@amazon.com>
@Poojita-Raj Poojita-Raj requested review from a team and reta as code owners October 26, 2022 21:30
Signed-off-by: Poojita Raj <poojiraj@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2022

Codecov Report

Merging #4946 (fba09ef) into main (d96da50) will decrease coverage by 0.50%.
The diff coverage is 73.33%.

@@             Coverage Diff              @@
##               main    #4946      +/-   ##
============================================
- Coverage     71.33%   70.82%   -0.51%     
+ Complexity    58324    57931     -393     
============================================
  Files          4689     4689              
  Lines        277043   277002      -41     
  Branches      40312    40311       -1     
============================================
- Hits         197621   196181    -1440     
- Misses        63412    64581    +1169     
- Partials      16010    16240     +230     
Impacted Files Coverage Δ
...sion/awareness/put/DecommissionRequestBuilder.java 0.00% <0.00%> (ø)
server/src/main/java/org/opensearch/Version.java 80.09% <100.00%> (-0.91%) ⬇️
...ecommission/awareness/put/DecommissionRequest.java 92.30% <100.00%> (+12.89%) ⬆️
...t/action/admin/cluster/RestDecommissionAction.java 85.71% <100.00%> (+2.38%) ⬆️
.../index/shard/IndexShardNotRecoveringException.java 0.00% <0.00%> (-100.00%) ⬇️
...adonly/AddIndexBlockClusterStateUpdateRequest.java 0.00% <0.00%> (-75.00%) ⬇️
...readonly/TransportVerifyShardIndexBlockAction.java 9.75% <0.00%> (-73.18%) ⬇️
...n/admin/indices/readonly/AddIndexBlockRequest.java 17.85% <0.00%> (-53.58%) ⬇️
...a/org/opensearch/tasks/TaskCancelledException.java 50.00% <0.00%> (-50.00%) ⬇️
.../org/opensearch/client/indices/AnalyzeRequest.java 31.00% <0.00%> (-48.00%) ⬇️
... and 480 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@reta reta merged commit 782dc59 into opensearch-project:main Oct 26, 2022
@reta
Copy link
Collaborator

reta commented Oct 26, 2022

Thanks a lot @Poojita-Raj !

@VachaShah VachaShah mentioned this pull request Oct 26, 2022
6 tasks
@Poojita-Raj Poojita-Raj deleted the VerifyVersionFix branch October 26, 2022 23:38
@Poojita-Raj Poojita-Raj self-assigned this Oct 28, 2022
ashking94 pushed a commit to ashking94/OpenSearch that referenced this pull request Nov 7, 2022
* Fix failing test: VerifyVersionConstantsIT

Signed-off-by: Poojita Raj <poojiraj@amazon.com>

* add changelog

Signed-off-by: Poojita Raj <poojiraj@amazon.com>

Signed-off-by: Poojita Raj <poojiraj@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants