Awareness attribute decommission backports #4970

imRishN · 2022-10-28T07:53:44Z

Description

Backports following PRs from Decommission Project -

Issues Resolved

[List any issues this PR will resolve]

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff
Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…ommissioning (opensearch-project#4084) * Add Executor to decommission node attribute * Decommission service implementation with cluster metadata * Master abdication changes to decommission local awareness leader * Update join validator changes to validate decommissioned node join request Signed-off-by: Rishab Nahata <rnnahata@amazon.com>

…oject#4261) * Add APIs (GET/PUT) to decommission awareness attribute Signed-off-by: Rishab Nahata <rnnahata@amazon.com>

* Recommission API service level changes Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com> Signed-off-by: Rishab Nahata <rnnahata@amazon.com>

* Add changes for Recommission API Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com> Signed-off-by: Rishab Nahata <rnnahata@amazon.com>

* Controlling discovery for decommissioned nodes Signed-off-by: Rishab Nahata <rnnahata@amazon.com>

…t#4800) * Fix decommission status update to non leader nodes Signed-off-by: Rishab Nahata <rnnahata@amazon.com>

…project#4751) * Add attribute name to query param and simplify GetDecommissionStateResponse Signed-off-by: Rishab Nahata <rnnahata@amazon.com>

* Fix bug in AwarenessAttributeDecommissionIT Signed-off-by: Rishab Nahata <rnnahata@amazon.com>

github-actions · 2022-10-28T08:00:08Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/5839/
CommitID: 1263b35
Please examine the workflow log, locate, and copy-paste the failure below, then iterate to green.
Is the failure a flaky test unrelated to your change?

Signed-off-by: Rishab Nahata <rnnahata@amazon.com>

github-actions · 2022-10-28T19:14:04Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/5865/
CommitID: 8c5377d

github-actions · 2022-10-31T17:47:43Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/5984/
CommitID: f27d3fe

codecov-commenter · 2022-10-31T17:53:20Z

Codecov Report

Merging #4970 (f27d3fe) into 2.x (26abe78) will increase coverage by 0.00%.
The diff coverage is 54.61%.

@@            Coverage Diff             @@
##                2.x    #4970    +/-   ##
==========================================
  Coverage     70.65%   70.66%            
- Complexity    57658    57829   +171     
==========================================
  Files          4620     4645    +25     
  Lines        276220   276891   +671     
  Branches      40422    40490    +68     
==========================================
+ Hits         195171   195671   +500     
- Misses        64771    64894   +123     
- Partials      16278    16326    +48

Impacted Files	Coverage Δ
.../delete/DeleteDecommissionStateRequestBuilder.java	`0.00% <0.00%> (ø)`
...reness/get/GetDecommissionStateRequestBuilder.java	`0.00% <0.00%> (ø)`
...sion/awareness/put/DecommissionRequestBuilder.java	`0.00% <0.00%> (ø)`
.../org/opensearch/client/support/AbstractClient.java	`33.25% <0.00%> (-1.01%)`	⬇️
...rg/opensearch/common/settings/ClusterSettings.java	`91.89% <ø> (ø)`
...eness/get/TransportGetDecommissionStateAction.java	`23.07% <23.07%> (ø)`
...arch/cluster/decommission/DecommissionService.java	`29.22% <29.22%> (ø)`
...rg/opensearch/cluster/coordination/JoinHelper.java	`85.56% <33.33%> (-1.74%)`	⬇️
...r/decommission/DecommissioningFailedException.java	`33.33% <33.33%> (ø)`
...on/awareness/get/GetDecommissionStateResponse.java	`42.85% <42.85%> (ø)`
... and 512 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Bukhtawar · 2022-11-02T05:57:18Z

server/src/main/java/org/opensearch/cluster/decommission/DecommissionAttributeMetadata.java

@@ -142,7 +142,7 @@ public String getWriteableName() {

    @Override
    public Version getMinimalSupportedVersion() {
-        return Version.V_3_0_0;
+        return Version.V_2_4_0;


Is this the only place we have versioning enabled? What happens to clusters running mixed version 2.0 and 2.4 lets say

Two more places -

DECOMMISSIONING_FAILED_EXCEPTION( org.opensearch.cluster.decommission.DecommissioningFailedException.class, org.opensearch.cluster.decommission.DecommissioningFailedException::new, 163, V_2_4_0 ), NODE_DECOMMISSIONED_EXCEPTION( org.opensearch.cluster.decommission.NodeDecommissionedException.class, org.opensearch.cluster.decommission.NodeDecommissionedException::new, 164, V_2_4_0 );

* Add DecommissionService and helper to execute awareness attribute decommissioning opensearch-project#4084 * Add APIs (GET/PUT) to decommission awareness attribute opensearch-project#4261 * Controlling discovery for decommissioned nodes opensearch-project#4590 * Fix decommission status update to non leader nodes opensearch-project#4800 * Remove redundant field from GetDecommissionStateResponse opensearch-project#4751 * Service Layer changes for Recommission API opensearch-project#4320 * Recommission api level support opensearch-project#4604 * Fix bug in AwarenessAttributeDecommissionIT opensearch-project#4822 Signed-off-by: Rishab Nahata <rnnahata@amazon.com>

* Awareness attribute decommission backports (#4970) * Add DecommissionService and helper to execute awareness attribute decommissioning #4084 * Add APIs (GET/PUT) to decommission awareness attribute #4261 * Controlling discovery for decommissioned nodes #4590 * Fix decommission status update to non leader nodes #4800 * Remove redundant field from GetDecommissionStateResponse #4751 * Service Layer changes for Recommission API #4320 * Recommission api level support #4604 * Fix bug in AwarenessAttributeDecommissionIT #4822 Signed-off-by: Rishab Nahata <rnnahata@amazon.com>

imRishN and others added 8 commits October 28, 2022 11:51

Add APIs (GET/PUT) to decommission awareness attribute (opensearch-pr…

79a4e06

…oject#4261) * Add APIs (GET/PUT) to decommission awareness attribute Signed-off-by: Rishab Nahata <rnnahata@amazon.com>

Service Layer changes for Recommission API (opensearch-project#4320)

d0bc7ea

* Recommission API service level changes Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com> Signed-off-by: Rishab Nahata <rnnahata@amazon.com>

Recommission api level support (opensearch-project#4604)

f12d9a7

* Add changes for Recommission API Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com> Signed-off-by: Rishab Nahata <rnnahata@amazon.com>

Controlling discovery for decommissioned nodes (opensearch-project#4590)

fb0e4d4

* Controlling discovery for decommissioned nodes Signed-off-by: Rishab Nahata <rnnahata@amazon.com>

Fix decommission status update to non leader nodes (opensearch-projec…

91123ba

…t#4800) * Fix decommission status update to non leader nodes Signed-off-by: Rishab Nahata <rnnahata@amazon.com>

Remove redundant field from GetDecommissionStateResponse (opensearch-…

cb20899

…project#4751) * Add attribute name to query param and simplify GetDecommissionStateResponse Signed-off-by: Rishab Nahata <rnnahata@amazon.com>

Fix bug in AwarenessAttributeDecommissionIT (opensearch-project#4822)

1263b35

* Fix bug in AwarenessAttributeDecommissionIT Signed-off-by: Rishab Nahata <rnnahata@amazon.com>

imRishN requested review from a team and reta as code owners October 28, 2022 07:53

imRishN changed the title ~~Decommission 2.x~~ Decommission Project Backports Oct 28, 2022

imRishN added 2 commits October 29, 2022 00:08

Change metadata version

55f8b33

Signed-off-by: Rishab Nahata <rnnahata@amazon.com>

Merge remote-tracking branch 'upstream/2.x' into decommission-2.x

8c5377d

Signed-off-by: Rishab Nahata <rnnahata@amazon.com>

imRishN changed the title ~~Decommission Project Backports~~ Awareness attribute decommission backports Oct 28, 2022

Merge branch '2.x' into decommission-2.x

f27d3fe

Bukhtawar reviewed Nov 2, 2022

View reviewed changes

imRishN mentioned this pull request Nov 2, 2022

Fix version check for 2.x release for awareness attribute decommission #5034

Merged

6 tasks

Bukhtawar approved these changes Nov 2, 2022

View reviewed changes

Bukhtawar merged commit b9f817f into opensearch-project:2.x Nov 2, 2022

imRishN mentioned this pull request Nov 3, 2022

[Backport 2.4] Awareness Attribute Decommission Backport #5062

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Awareness attribute decommission backports #4970

Awareness attribute decommission backports #4970

imRishN commented Oct 28, 2022

github-actions bot commented Oct 28, 2022

github-actions bot commented Oct 28, 2022

github-actions bot commented Oct 31, 2022

codecov-commenter commented Oct 31, 2022

Bukhtawar Nov 2, 2022

imRishN Nov 2, 2022

Awareness attribute decommission backports #4970

Awareness attribute decommission backports #4970

Conversation

imRishN commented Oct 28, 2022

Description

Issues Resolved

Check List

github-actions bot commented Oct 28, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Oct 28, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Oct 31, 2022

Gradle Check (Jenkins) Run Completed with:

codecov-commenter commented Oct 31, 2022

Codecov Report

Bukhtawar Nov 2, 2022

Choose a reason for hiding this comment

imRishN Nov 2, 2022

Choose a reason for hiding this comment