Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.4]Revert "Cluster manager task throttling feature [Final PR] (#5071) #5203

Merged
merged 4 commits into from
Nov 10, 2022

Conversation

Bukhtawar
Copy link
Collaborator

@Bukhtawar Bukhtawar commented Nov 10, 2022

This reverts commit e0d1c2e.

Signed-off-by: Bukhtawar Khan bukhtawa@amazon.com

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…h-project#4986) (opensearch-project#5071)"

This reverts commit e0d1c2e.

Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com>
@Bukhtawar Bukhtawar requested review from a team and reta as code owners November 10, 2022 17:44
@Bukhtawar Bukhtawar changed the title Revert "Cluster manager task throttling feature [Final PR] (#5071) [Backport 2.4]Revert "Cluster manager task throttling feature [Final PR] (#5071) Nov 10, 2022
@andrross
Copy link
Member

Why is this being reverted?

Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com>
@andrross
Copy link
Member

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com>
Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@andrross
Copy link
Member

I found the following explanation for this revert out-of-band. Going to capture it here for posterity in case folks want to understand why this was reverted from the 2.4 release:

we are modifying the way data nodes submit task to cluster manager and hence it requires bit data nodes and cluster manager understand the new format. Also since the cluster manager could now potentially throw a throttling exception it required data nodes to understand the new exception and hence data node and master node had to be coupled. However we should ideally have allowed mixed clusters to work without any BWC complexity, which was the miss

@Bukhtawar please correct or update as necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants