Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Revert changes in AbstractPointGeometryFieldMapper #5260

Merged
merged 1 commit into from
Nov 15, 2022

Commits on Nov 15, 2022

  1. Revert changes in AbstractPointGeometryFieldMapper (#5246)

    The change made in AbstractPointGeometryFieldMapper class
    with commit 0503897 introduced
    a performace degradation during point data indexing. Reverting it therefore.
    
    The change is about consolidating array format parsing code for point type in a single place to acheive following benefits.
    1. Allow plugins to override array parsing logic. Plugins can add its own parsing logic for point field by providing object parser. However, it cannot override array format. Therefore, plugin have to use whatever implemented in AbstractPointGeometryFieldMapper class.
    2. Enhanced code quality by removing duplicated code
    
    There is no change in functionality because 1. There is no change in functionality in OpenSearch and 2. No plugins have its own parsing logic for point data in array format yet.
    
    Signed-off-by: Heemin Kim <heemin@amazon.com>
    
    Signed-off-by: Heemin Kim <heemin@amazon.com>
    (cherry picked from commit 3583b80)
    Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
    github-actions[bot] committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    0a5f8d3 View commit details
    Browse the repository at this point in the history