Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for windows failing test InternalDistributionArchiveCheckPluginFu… #5405

Merged

Conversation

Poojita-Raj
Copy link
Contributor

…ncTest

Signed-off-by: Poojita Raj poojiraj@amazon.com

Description

Resolves the failure for InternalDistributionArchiveCheckPluginFuncTest on windows. This is because the build of darwin tar gets skipped on windows so instead of the failure condition we check for on other machines, we should be checking if it gets skipped on windows.

To reproduce failure - on windows machine, run -

./gradlew :build-tools:integTest --tests "org.opensearch.gradle.internal.InternalDistributionArchiveCheckPluginFuncTest"

Issues Resolved

Resolves #5324

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…ncTest

Signed-off-by: Poojita Raj <poojiraj@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

Codecov Report

Merging #5405 (081eab4) into 1.x (25593d6) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                1.x    #5405      +/-   ##
============================================
- Coverage     77.84%   77.80%   -0.04%     
- Complexity    63400    63415      +15     
============================================
  Files          4454     4454              
  Lines        275052   275052              
  Branches      41175    41175              
============================================
- Hits         214101   213994     -107     
- Misses        44017    44124     +107     
  Partials      16934    16934              
Impacted Files Coverage Δ
...g/opensearch/index/analysis/CharFilterFactory.java 0.00% <0.00%> (-100.00%) ⬇️
...ava/org/opensearch/action/NoSuchNodeException.java 0.00% <0.00%> (-50.00%) ⬇️
...rch/index/engine/RefreshFailedEngineException.java 50.00% <0.00%> (-50.00%) ⬇️
...h/index/engine/EngineCreationFailureException.java 50.00% <0.00%> (-50.00%) ⬇️
.../action/ingest/SimulatePipelineRequestBuilder.java 0.00% <0.00%> (-50.00%) ⬇️
...gling/import_index/ImportDanglingIndexRequest.java 43.75% <0.00%> (-50.00%) ⬇️
...search/discovery/zen/PublishClusterStateStats.java 58.33% <0.00%> (-37.51%) ⬇️
...search/discovery/zen/PendingClusterStateStats.java 56.00% <0.00%> (-36.00%) ⬇️
...r/src/main/java/org/opensearch/http/HttpUtils.java 33.33% <0.00%> (-33.34%) ⬇️
...va/org/opensearch/node/AdaptiveSelectionStats.java 22.22% <0.00%> (-33.34%) ⬇️
... and 470 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Poojita-Raj Poojita-Raj merged commit f7cadb3 into opensearch-project:1.x Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants