Fix for windows failure InternalDistributionArchiveSetupPluginFuncTest #5417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Poojita Raj <poojiraj@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
reta
reviewed
Nov 30, 2022
| file("producer-tar/build/install/snapshot-2.0.txt").exists() | ||
| } else { | ||
| when: | ||
| def result = gradleRunner("copyArchive").build() |
There was a problem hiding this comment.
I think we should add a test case for Windows ZIP archive (for Windows platform), to check the archive distribution also works on Windows (we had issues with that in the past), what do you think @Poojita-Raj?
There was a problem hiding this comment.
Hey @reta, thanks for the review! Yes, I think we can do that, however do you believe that's a blocker for windows readiness for the 1.3.7 release? Or would it be a nice to have add on?
There was a problem hiding this comment.
Thanks @Poojita-Raj , I think it is nice to have but certainly not a blocker
There was a problem hiding this comment.
Thanks @reta, I've opened another issue for your comment to track it, and will merge this in for now.
reta
approved these changes
Dec 1, 2022
mch2
approved these changes
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Poojita Raj poojiraj@amazon.com
Description
Failure on windows for the InternalDistributionArchiveSetupPluginFuncTest is unexpected. Fails with "registered distribution provides archives and directory variant".
This is because -
To get the test passing again, we check for expected conditions on windows and non-windows machines.
Issues Resolved
Resolves #5324
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.