Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AUTO] [main] Added bwc version 2.4.2. #5560

Closed
wants to merge 2 commits into from

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

I've noticed that a new tag 2.4.1 was pushed, and added a bwc version 2.4.2.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
@reta
Copy link
Collaborator

reta commented Dec 13, 2022

@dblock seems like changes in Version.java are missed?

Signed-off-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
@dblock
Copy link
Member

dblock commented Dec 13, 2022

@reta We're doing funky things here on main. See if this is OK? Are those comments useful?

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@reta
Copy link
Collaborator

reta commented Dec 13, 2022

@reta We're doing funky things here on main. See if this is OK? Are those comments useful?

@dblock unfortunately they still are:

/home/runner/work/OpenSearch/OpenSearch/server/src/main/java/org/opensearch/Version.java:86: error: cannot find symbol

    public static final Version V_2_4_1 = new Version(2040199, org.apache.lucene.util.Version.LUCENE_9_4_2);
                                                                                             ^
  symbol:   variable LUCENE_9_4_2
> Task :server:compileJava
  location: class Version
/home/runner/work/OpenSearch/OpenSearch/server/src/main/java/org/opensearch/Version.java:89: error: cannot find symbol
    public static final Version V_2_4_2 = new Version(2040299, org.apache.lucene.util.Version.LUCENE_9_4_2);
                                                                                             ^
  symbol:   variable LUCENE_9_4_2
  location: class Version
/home/runner/work/OpenSearch/OpenSearch/server/src/main/java/org/opensearch/Version.java:90: error: cannot find symbol
    public static final Version V_2_5_0 = new Version(2050099, org.apache.lucene.util.Version.LUCENE_9_4_2);
                                                                                             ^
  symbol:   variable LUCENE_9_4_2
  location: class Version

The issue here is that we (OpenSearch) build our own Apache Lucene snapshots and publish them, I sadly don't know the details how often we do that, but we have not done that in a while, and hence we have pretty old 9.5.0 snapshots without 9.4.2 reference :(

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.indices.stats.IndexStatsIT.testFilterCacheStats
      1 org.opensearch.cluster.allocation.AwarenessAllocationIT.testThreeZoneOneReplicaWithForceZoneValueAndLoadAwareness

@dreamer-89
Copy link
Member

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.indices.stats.IndexStatsIT.testFilterCacheStats
      1 org.opensearch.cluster.allocation.AwarenessAllocationIT.testThreeZoneOneReplicaWithForceZoneValueAndLoadAwareness

#2501

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@dreamer-89
Copy link
Member

@reta We're doing funky things here on main. See if this is OK? Are those comments useful?

@dblock unfortunately they still are:

/home/runner/work/OpenSearch/OpenSearch/server/src/main/java/org/opensearch/Version.java:86: error: cannot find symbol

    public static final Version V_2_4_1 = new Version(2040199, org.apache.lucene.util.Version.LUCENE_9_4_2);
                                                                                             ^
  symbol:   variable LUCENE_9_4_2
> Task :server:compileJava
  location: class Version
/home/runner/work/OpenSearch/OpenSearch/server/src/main/java/org/opensearch/Version.java:89: error: cannot find symbol
    public static final Version V_2_4_2 = new Version(2040299, org.apache.lucene.util.Version.LUCENE_9_4_2);
                                                                                             ^
  symbol:   variable LUCENE_9_4_2
  location: class Version
/home/runner/work/OpenSearch/OpenSearch/server/src/main/java/org/opensearch/Version.java:90: error: cannot find symbol
    public static final Version V_2_5_0 = new Version(2050099, org.apache.lucene.util.Version.LUCENE_9_4_2);
                                                                                             ^
  symbol:   variable LUCENE_9_4_2
  location: class Version

The issue here is that we (OpenSearch) build our own Apache Lucene snapshots and publish them, I sadly don't know the details how often we do that, but we have not done that in a while, and hence we have pretty old 9.5.0 snapshots without 9.4.2 reference :(

@reta: Thanks for sharing this. I see

@reta We're doing funky things here on main. See if this is OK? Are those comments useful?

@dblock unfortunately they still are:

/home/runner/work/OpenSearch/OpenSearch/server/src/main/java/org/opensearch/Version.java:86: error: cannot find symbol

    public static final Version V_2_4_1 = new Version(2040199, org.apache.lucene.util.Version.LUCENE_9_4_2);
                                                                                             ^
  symbol:   variable LUCENE_9_4_2
> Task :server:compileJava
  location: class Version
/home/runner/work/OpenSearch/OpenSearch/server/src/main/java/org/opensearch/Version.java:89: error: cannot find symbol
    public static final Version V_2_4_2 = new Version(2040299, org.apache.lucene.util.Version.LUCENE_9_4_2);
                                                                                             ^
  symbol:   variable LUCENE_9_4_2
  location: class Version
/home/runner/work/OpenSearch/OpenSearch/server/src/main/java/org/opensearch/Version.java:90: error: cannot find symbol
    public static final Version V_2_5_0 = new Version(2050099, org.apache.lucene.util.Version.LUCENE_9_4_2);
                                                                                             ^
  symbol:   variable LUCENE_9_4_2
  location: class Version

The issue here is that we (OpenSearch) build our own Apache Lucene snapshots and publish them, I sadly don't know the details how often we do that, but we have not done that in a while, and hence we have pretty old 9.5.0 snapshots without 9.4.2 reference :(

There seems to be lucene snapshot workflow which generates the snapshots but needs aws account creds. @dblock @nknize : Any idea how do we trigger this job ?

@reta
Copy link
Collaborator

reta commented Dec 14, 2022

There seems to be lucene snapshot workflow which generates the snapshots but needs aws account creds.

Exactly :(

@nknize
Copy link
Collaborator

nknize commented Dec 14, 2022

We shouldn't bump Lucene versions without triggering a snapshot build or updating the versions file with the next release (and updating shas). This should happen in a dedicated PR. I went ahead and triggered the next snapshot build.

https://github.com/opensearch-project/OpenSearch/actions/runs/3690669028

@dreamer-89
Copy link
Member

We shouldn't bump Lucene versions without triggering a snapshot build or updating the versions file with the next release (and updating shas). This should happen in a dedicated PR. I went ahead and triggered the next snapshot build.

https://github.com/opensearch-project/OpenSearch/actions/runs/3690669028

The publish-snapshots step is failing @nknize

publish-snapshots
OpenIDConnect provider's HTTPS certificate doesn't match configured thumbprint

@nknize
Copy link
Collaborator

nknize commented Dec 14, 2022

/cc @mch2 can you take a look when you get a chance?

@mch2
Copy link
Member

mch2 commented Dec 14, 2022

/cc @mch2 can you take a look when you get a chance?

Seems like flaky behavior with OIDC, I've added the most current GH thumbprint manually and kicked off a run of lucene branch_9_4 - created version 9.4.3-snapshot-bb7785b and branch_9x - created version 9.5.0-snapshot-d5cef1c . For more info on the thumbprints - aws-actions/configure-aws-credentials#395.

There seems to be lucene snapshot workflow which generates the snapshots but needs aws account creds.

Exactly :(

Yep my fault sorry about this, I never pushed the cdk code used. I reused this cdk project from data-prepper to use an s3 bucket as our maven repo. Will move all this cdk config to a folder in core.

@dreamer-89 dreamer-89 mentioned this pull request Dec 14, 2022
6 tasks
@dreamer-89
Copy link
Member

Closing this in favour of #5570

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants