Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky Segment Replication test testStartReplicaAfterPrimaryIndexesDocs. #5722

Merged
merged 2 commits into from
Jan 7, 2023
Merged

Fix flaky Segment Replication test testStartReplicaAfterPrimaryIndexesDocs. #5722

merged 2 commits into from
Jan 7, 2023
+49 −16

Commits on Jan 6, 2023

  1. Fix flaky SR test testStartReplicaAfterPrimaryIndexesDocs. 

    This test was failing because we are validating post recovery if a shard is able to perform segrep while also performing validation if a passed in checkopint.  In the post recovery test this checkpoint is always empty, yet the shard will be ahead of this checkpoint after docs are indexed.  This change differentiates shard validation from checkpoint validation.

Signed-off-by: Marc Handalian <handalm@amazon.com>

Fix spotless.

Signed-off-by: Marc Handalian <handalm@amazon.com>

Fix testIsSegmentReplicationAllowed_WrongEngineType.

Signed-off-by: Marc Handalian <handalm@amazon.com>

Update warn logs in isSegmentReplicationAllowed.

Signed-off-by: Marc Handalian <handalm@amazon.com>
    @mch2
    mch2 committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    4852671 View commit details
    Browse the repository at this point in the history

  2. PR feedback. 

    Signed-off-by: Marc Handalian <handalm@amazon.com>
    @mch2
    mch2 committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    7b2bc53 View commit details
    Browse the repository at this point in the history