-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] Enable SearchableSnapshotIT to run during build #5939
Conversation
Gradle Check (Jenkins) Run Completed with:
|
Looks like the feature flag code needs to be backported before we can merge this in. |
Found the backport PR - #5707 |
Previously this test required the feature flag to be set as a system property, otherwise the test did nothing. This change programmatically sets the feature flag to allow the test to run during all builds. I ran the following command overnight (probably at least a couple thousand iterations) on a dev machine and saw no failures, so I have confidence this test is not flaky: ``` run-one-until-failure ./gradlew ':server:internalClusterTest' --tests "org.opensearch.snapshots.SearchableSnapshotIT" ``` Signed-off-by: Andrew Ross <andrross@amazon.com> Signed-off-by: Andrew Ross <andrross@amazon.com> (cherry picked from commit 901cd69) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
b014bb7
to
bf32962
Compare
Rebased |
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## 2.x #5939 +/- ##
============================================
- Coverage 70.49% 70.38% -0.11%
- Complexity 58887 58900 +13
============================================
Files 4766 4766
Lines 282418 282418
Branches 41130 41130
============================================
- Hits 199077 198774 -303
- Misses 66670 67018 +348
+ Partials 16671 16626 -45
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Previously this test required the feature flag to be set as a system property, otherwise the test did nothing. This change programmatically sets the feature flag to allow the test to run during all builds. I ran the following command overnight (probably at least a couple thousand iterations) on a dev machine and saw no failures, so I have confidence this test is not flaky: ``` run-one-until-failure ./gradlew ':server:internalClusterTest' --tests "org.opensearch.snapshots.SearchableSnapshotIT" ``` Signed-off-by: Andrew Ross <andrross@amazon.com> Signed-off-by: Andrew Ross <andrross@amazon.com> (cherry picked from commit 901cd69) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Andrew Ross <andrross@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Backport 901cd69 from #5937.