Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Enable SearchableSnapshotIT to run during build #5939

Merged
merged 1 commit into from
Jan 20, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 901cd69 from #5937.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@kotwanikunal
Copy link
Member

Gradle Check (Jenkins) Run Completed with:

 java.lang.IllegalArgumentException: unknown setting [opensearch.experimental.feature.searchable_snapshot.enabled] please check that any required plugins are installed, or check the breaking changes documentation for removed settings

Looks like the feature flag code needs to be backported before we can merge this in.

@kotwanikunal
Copy link
Member

Gradle Check (Jenkins) Run Completed with:

 java.lang.IllegalArgumentException: unknown setting [opensearch.experimental.feature.searchable_snapshot.enabled] please check that any required plugins are installed, or check the breaking changes documentation for removed settings

Looks like the feature flag code needs to be backported before we can merge this in.

Found the backport PR - #5707

Previously this test required the feature flag to be set as a system
property, otherwise the test did nothing. This change programmatically
sets the feature flag to allow the test to run during all builds.
I ran the following command overnight (probably at least a couple
thousand iterations) on a dev machine and saw no failures, so I have
confidence this test is not flaky:

```
run-one-until-failure ./gradlew ':server:internalClusterTest' --tests "org.opensearch.snapshots.SearchableSnapshotIT"
```

Signed-off-by: Andrew Ross <andrross@amazon.com>

Signed-off-by: Andrew Ross <andrross@amazon.com>
(cherry picked from commit 901cd69)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@kotwanikunal kotwanikunal force-pushed the backport/backport-5937-to-2.x branch from b014bb7 to bf32962 Compare January 19, 2023 22:11
@kotwanikunal
Copy link
Member

Rebased backport/backport-5937-to-2.x on 2.x.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.indices.replication.SegmentReplicationIT.testReplicationAfterPrimaryRefreshAndFlush

@codecov-commenter
Copy link

Codecov Report

Merging #5939 (bf32962) into 2.x (cdb2b26) will decrease coverage by 0.11%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                2.x    #5939      +/-   ##
============================================
- Coverage     70.49%   70.38%   -0.11%     
- Complexity    58887    58900      +13     
============================================
  Files          4766     4766              
  Lines        282418   282418              
  Branches      41130    41130              
============================================
- Hits         199077   198774     -303     
- Misses        66670    67018     +348     
+ Partials      16671    16626      -45     
Impacted Files Coverage Δ
...adonly/AddIndexBlockClusterStateUpdateRequest.java 0.00% <0.00%> (-75.00%) ⬇️
...port/ResponseHandlerFailureTransportException.java 0.00% <0.00%> (-60.00%) ⬇️
...readonly/TransportVerifyShardIndexBlockAction.java 9.75% <0.00%> (-58.54%) ⬇️
...ch/transport/ReceiveTimeoutTransportException.java 50.00% <0.00%> (-50.00%) ⬇️
...cluster/coordination/PendingClusterStateStats.java 20.00% <0.00%> (-48.00%) ⬇️
...adcast/BroadcastShardOperationFailedException.java 55.55% <0.00%> (-44.45%) ⬇️
...pensearch/indices/breaker/CircuitBreakerStats.java 27.77% <0.00%> (-41.67%) ⬇️
.../admin/cluster/reroute/ClusterRerouteResponse.java 60.00% <0.00%> (-40.00%) ⬇️
...indices/readonly/TransportAddIndexBlockAction.java 20.68% <0.00%> (-37.94%) ⬇️
...luster/routing/allocation/RoutingExplanations.java 62.06% <0.00%> (-37.94%) ⬇️
... and 501 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@andrross andrross merged commit 023b0bc into 2.x Jan 20, 2023
@andrross andrross deleted the backport/backport-5937-to-2.x branch January 20, 2023 16:40
kotwanikunal pushed a commit that referenced this pull request Jan 25, 2023
Previously this test required the feature flag to be set as a system
property, otherwise the test did nothing. This change programmatically
sets the feature flag to allow the test to run during all builds.
I ran the following command overnight (probably at least a couple
thousand iterations) on a dev machine and saw no failures, so I have
confidence this test is not flaky:

```
run-one-until-failure ./gradlew ':server:internalClusterTest' --tests "org.opensearch.snapshots.SearchableSnapshotIT"
```

Signed-off-by: Andrew Ross <andrross@amazon.com>

Signed-off-by: Andrew Ross <andrross@amazon.com>
(cherry picked from commit 901cd69)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Signed-off-by: Andrew Ross <andrross@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants