Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Add update settings allowlist for searchable snapshot #5967

Merged
merged 1 commit into from
Jan 22, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 011ff63 from #5907.

* Add update settings allowlist for searchable snapshot

Allow search related settings to be updated for searchable snapshots.

Signed-off-by: Rabi Panda <adnapibar@gmail.com>

* Update Changelog

Signed-off-by: Rabi Panda <adnapibar@gmail.com>

* Add feature flag check

Signed-off-by: Rabi Panda <adnapibar@gmail.com>

* Use set instead of string arrays for allowed list

Signed-off-by: Rabi Panda <adnapibar@gmail.com>

* Update Changelog

Signed-off-by: Rabi Panda <adnapibar@gmail.com>

Signed-off-by: Rabi Panda <adnapibar@gmail.com>
(cherry picked from commit 011ff63)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.cluster.allocation.AwarenessAllocationIT.testThreeZoneOneReplicaWithForceZoneValueAndLoadAwareness

@codecov-commenter
Copy link

Codecov Report

Merging #5967 (28ca159) into 2.x (23c23dc) will increase coverage by 0.03%.
The diff coverage is 51.74%.

@@             Coverage Diff              @@
##                2.x    #5967      +/-   ##
============================================
+ Coverage     70.40%   70.43%   +0.03%     
- Complexity    58879    58928      +49     
============================================
  Files          4766     4768       +2     
  Lines        282430   282572     +142     
  Branches      41129    41148      +19     
============================================
+ Hits         198840   199032     +192     
+ Misses        66925    66890      -35     
+ Partials      16665    16650      -15     
Impacted Files Coverage Δ
...ensearch/analysis/common/CommonAnalysisPlugin.java 92.06% <ø> (ø)
...nsearch/ingest/geoip/DatabaseReaderLazyLoader.java 75.00% <ø> (ø)
...n/java/org/opensearch/painless/PainlessPlugin.java 80.95% <ø> (ø)
...g/opensearch/percolator/PercolateQueryBuilder.java 83.00% <ø> (ø)
...ain/java/org/opensearch/systemd/SystemdPlugin.java 74.41% <ø> (ø)
...in/java/org/opensearch/transport/Netty4Plugin.java 73.68% <ø> (ø)
...earch/plugin/discovery/gce/GceDiscoveryPlugin.java 20.83% <ø> (ø)
...rg/opensearch/repositories/s3/S3BlobContainer.java 37.97% <ø> (-1.69%) ⬇️
...g/opensearch/transport/nio/NioTransportPlugin.java 25.00% <ø> (ø)
...earch/action/search/AbstractSearchAsyncAction.java 77.38% <ø> (-0.30%) ⬇️
... and 535 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kotwanikunal kotwanikunal merged commit f847fd5 into 2.x Jan 22, 2023
@github-actions github-actions bot deleted the backport/backport-5907-to-2.x branch January 22, 2023 23:17
kotwanikunal pushed a commit that referenced this pull request Jan 25, 2023
* Add update settings allowlist for searchable snapshot

Allow search related settings to be updated for searchable snapshots.

Signed-off-by: Rabi Panda <adnapibar@gmail.com>

* Update Changelog

Signed-off-by: Rabi Panda <adnapibar@gmail.com>

* Add feature flag check

Signed-off-by: Rabi Panda <adnapibar@gmail.com>

* Use set instead of string arrays for allowed list

Signed-off-by: Rabi Panda <adnapibar@gmail.com>

* Update Changelog

Signed-off-by: Rabi Panda <adnapibar@gmail.com>

Signed-off-by: Rabi Panda <adnapibar@gmail.com>
(cherry picked from commit 011ff63)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Signed-off-by: Rabi Panda <adnapibar@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants