[BUG] javadoc warnings not causing failures #5996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reta
requested review from
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
adnapibar,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah and
xuezhou25
as code owners
|
It works! |
I will fix that tomorrow :) thanks @andrross ! |
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
reta
commented
Jan 25, 2023
| @@ -40,6 +40,11 @@ opensearchplugin { | |||
| classname 'org.opensearch.painless.PainlessModulePlugin' | |||
| } | |||
|
|
|||
| ext { | |||
| // Do not fail on `javadoc` warning (ANTLR generated code) | |||
| failOnJavadocWarning = false | |||
reta
commented
Jan 25, 2023
| @@ -515,7 +515,7 @@ public void setNextDocId(int docId) throws IOException { | |||
| } | |||
|
|
|||
| /** | |||
| * Set the {@link #size()} and ensure that the {@link #values} array can | |||
| * Set the {@link #size()} and ensure that the internal values array can | |||
There was a problem hiding this comment.
{@link #values} - javadoc complains (for a reason) that private final values is not accessible, makes sense.
Gradle Check (Jenkins) Run Completed with:
|
|
Unrelated to this PR, but my change from yesterday seems to work and we can now safely add the backport labels before the PR is merged |
andrross
approved these changes
Jan 25, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 25, 2023
Signed-off-by: Andriy Redko <andriy.redko@aiven.io> (cherry picked from commit 665ec6c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
andrross
pushed a commit
that referenced
this pull request
Jan 25, 2023
Signed-off-by: Andriy Redko <andriy.redko@aiven.io> (cherry picked from commit 665ec6c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andriy Redko andriy.redko@aiven.io
Description
javadocwarnings not causing failuresIssues Resolved
Closes #5995
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.