Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require MediaType in Strings.toString API #6009

Merged
merged 4 commits into from
Jan 25, 2023
Merged

Require MediaType in Strings.toString API #6009

merged 4 commits into from
Jan 25, 2023

Commits on Jan 25, 2023

  1. Require MediaType in Strings.toString API 

    String.toString is tightly coupled to XContentType.JSON which blocks
modularizing foundation classes from the server module to the core library. This
change refactors the String.toString API to accept a generic MediaType such that
the toString implementation detail is encapsulated to the :server module.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
    @nknize
    nknize committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    9a48c7d View commit details
    Browse the repository at this point in the history

  2. update changelog...ugh 

    Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
    @nknize
    nknize committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    ed67a95 View commit details
    Browse the repository at this point in the history

  3. pr change 1 

    Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
    @nknize
    nknize committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    93e3cef View commit details
    Browse the repository at this point in the history

  4. pr change 2 

    Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
    @nknize
    nknize committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    64cde67 View commit details
    Browse the repository at this point in the history