-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Purge remote translog basis the latest metadata for remote-backed indexes #6086
Merged
gbbafna
merged 16 commits into
opensearch-project:main
from
ashking94:tx-safe-remote-delete
Feb 3, 2023
Merged
Purge remote translog basis the latest metadata for remote-backed indexes #6086
gbbafna
merged 16 commits into
opensearch-project:main
from
ashking94:tx-safe-remote-delete
Feb 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashking94
added
Storage:Durability
Issues and PRs related to the durability framework
skip-changelog
v2.6.0
'Issues and PRs related to version v2.6.0'
labels
Jan 30, 2023
ashking94
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
adnapibar,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah and
xuezhou25
as code owners
January 30, 2023 17:46
6 tasks
ashking94
changed the title
Purge translog basis the latest metadata for remote-backed indexes
Purge remote translog basis the latest metadata for remote-backed indexes
Jan 30, 2023
Signed-off-by: Ashish Singh <ssashish@amazon.com>
Signed-off-by: Ashish Singh <ssashish@amazon.com>
Signed-off-by: Ashish Singh <ssashish@amazon.com>
ashking94
force-pushed
the
tx-safe-remote-delete
branch
from
February 1, 2023 11:23
9d30ec8
to
b5c0f7f
Compare
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Ashish Singh <ssashish@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Ashish Singh <ssashish@amazon.com>
Signed-off-by: Ashish Singh <ssashish@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
gbbafna
reviewed
Feb 2, 2023
server/src/main/java/org/opensearch/index/translog/RemoteFsTranslog.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ashish Singh <ssashish@amazon.com>
gbbafna
approved these changes
Feb 2, 2023
Gradle Check (Jenkins) Run Completed with:
|
Build failed due to
|
Signed-off-by: Ashish Singh <ssashish@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Build succeeded. @gbbafna |
6 tasks
ashking94
pushed a commit
to ashking94/OpenSearch
that referenced
this pull request
Feb 6, 2023
…exes (opensearch-project#6086) * Deleting remote translog considering latest remote metadata Co-authored-by: Gaurav Bafna <gbbafna@amazon.com> Signed-off-by: Ashish Singh <ssashish@amazon.com> (cherry picked from commit 54ce423) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport 2.x
Backport to 2.x branch
skip-changelog
Storage:Durability
Issues and PRs related to the durability framework
v2.6.0
'Issues and PRs related to version v2.6.0'
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During failover or relocation of primary shard, during initialisation of RemoteFsTranslog, we read remote translog metadata and download translog and checkpoint file for the corresponding primary term and generation as present in remote translog metadata file. After a flush, we clear *.tlog and *.ckp files, but the remote metadata file continues to hold references to the deleted generations. We need to handle the same.
We should delete remote translog considering the latest metadata file uploaded. The tlog/ckp files referenced by that metadata file should not be deleted . By doing this we will be able to restore translog from that metadata.
Issues Resolved
#5845
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.