[opensearch-project/geospatial#212] Fixing the IT for GeoTilesAggrega… #6120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navneet1v
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
adnapibar,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah and
xuezhou25
as code owners
navneet1v
added
Geospatial
flaky-test
heemin32
reviewed
Feb 1, 2023
...ava/org/opensearch/geo/search/aggregations/bucket/AbstractGeoBucketAggregationIntegTest.java
Outdated
Show resolved
Hide resolved
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #6120 +/- ##
============================================
- Coverage 70.77% 70.73% -0.05%
+ Complexity 58744 58687 -57
============================================
Files 4775 4775
Lines 281000 281000
Branches 40592 40592
============================================
- Hits 198873 198759 -114
- Misses 65812 65906 +94
- Partials 16315 16335 +20
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Gradle Check (Jenkins) Run Completed with:
|
|
@nknize please check the PR. |
nknize
approved these changes
Feb 2, 2023
| final GeoPoint topLeft = new GeoPoint(); | ||
| final GeoPoint bottomRight = new GeoPoint(); | ||
| assert geometry != null; | ||
| GeoBoundsHelper.updateBoundsForGeometry(geometry, topLeft, bottomRight); | ||
| final Set<String> geoHashes = new HashSet<>(); | ||
| for (int precision = MAX_PRECISION_FOR_GEO_SHAPES_AGG_TESTING; precision > 0; precision--) { | ||
| if (precision > 2 && !geometryDocValue.isIntersectingRectangle(boundingRectangleForGeoShapesAgg)) { | ||
| if (precision > MIN_PRECISION_WITHOUT_BB_AGGS && !intersectingWithBB) { |
There was a problem hiding this comment.
nit. Try to avoid negatives... they can be easily missed...
Suggested change
| if (precision > MIN_PRECISION_WITHOUT_BB_AGGS && !intersectingWithBB) { | |
| if (precision > MIN_PRECISION_WITHOUT_BB_AGGS && intersectingWithBB == false) { |
| final GeoPoint topLeft = new GeoPoint(); | ||
| final GeoPoint bottomRight = new GeoPoint(); | ||
| assert geometry != null; | ||
| GeoBoundsHelper.updateBoundsForGeometry(geometry, topLeft, bottomRight); | ||
| final Set<String> geoTiles = new HashSet<>(); | ||
| for (int precision = MAX_PRECISION_FOR_GEO_SHAPES_AGG_TESTING; precision > 0; precision--) { | ||
| if (precision > MIN_PRECISION_WITHOUT_BB_AGGS && !intersectingWithBB) { |
There was a problem hiding this comment.
same nit:
Suggested change
| if (precision > MIN_PRECISION_WITHOUT_BB_AGGS && !intersectingWithBB) { | |
| if (precision > MIN_PRECISION_WITHOUT_BB_AGGS && intersectingWithBB == false) { |
|
Will fix the nit picks and will raise the pr again. |
…tion. Signed-off-by: Navneet Verma <navneev@amazon.com>
Signed-off-by: Navneet Verma <navneev@amazon.com>
|
@nknize updated the PR by fixing nitpicks. |
Gradle Check (Jenkins) Run Completed with:
|
nknize
approved these changes
Feb 3, 2023
heemin32
pushed a commit
to heemin32/OpenSearch
that referenced
this pull request
Jun 28, 2023
opensearch-project#6120) Fixing the IT for GeoTilesAggregation. Signed-off-by: Navneet Verma <navneev@amazon.com>
andrross
pushed a commit
that referenced
this pull request
Jun 30, 2023
* Add GeoTile and GeoHash Grid aggregations on GeoShapes. (#5589) Src files for GeoTile and GeoHash Aggregations on GeoShape with integration tests. Signed-off-by: Navneet Verma <navneev@amazon.com> * [opensearch-project/geospatial#212] Fixing the IT for GeoTilesAggrega… (#6120) Fixing the IT for GeoTilesAggregation. Signed-off-by: Navneet Verma <navneev@amazon.com> * [#6187, #6222] Fixing the GeoShapes GeoHash and GeoTile Aggregations Integration tests. (#6242) Changes done: * Fixed the ArrayIndexOutOfBoundsException. * Reduced the precision for GeoShapes Aggregation IT testing. Signed-off-by: Navneet Verma <navneev@amazon.com> * [#7101] Fixing the GeoTileIT#testMultivaluedGeoPointsAggregation test case. (#7166) The issue was happening because we encode the GeoPoint as long and error comes in the precision due to that encoding. The error was not taken care while generating the exepected tiles count for execpected output. Signed-off-by: Navneet Verma <navneev@amazon.com> --------- Signed-off-by: Navneet Verma <navneev@amazon.com> Signed-off-by: Heemin Kim <heemin@amazon.com> Co-authored-by: Navneet Verma <navneev@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing the IT for GeoTilesAggregation.
Signed-off-by: Navneet Verma navneev@amazon.com
Issues Resolved
opensearch-project/geospatial#212
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.