Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version 1.3.9 #6174

Merged
merged 1 commit into from
Feb 3, 2023
Merged

Add version 1.3.9 #6174

merged 1 commit into from
Feb 3, 2023

Conversation

andrross
Copy link
Member

@andrross andrross commented Feb 3, 2023

BWC tests are failing on 2.x due to the release of 1.3.8.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Andrew Ross <andrross@amazon.com>
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2023

Gradle Check (Jenkins) Run Completed with:

@reta reta merged commit 31e0d0b into opensearch-project:2.x Feb 3, 2023
@reta
Copy link
Collaborator

reta commented Feb 3, 2023

Thanks @andrross , I think this step was automated, or not anymore?

@andrross andrross deleted the v139 branch February 3, 2023 19:07
@andrross
Copy link
Member Author

andrross commented Feb 3, 2023

Thanks @andrross , I think this step was automated, or not anymore?

@reta The version increment on the 1.3 branch is automated (#6163), but the change for BWC on the 2.x branch seems not to be automated (#4709 #5564).

@andrross
Copy link
Member Author

andrross commented Feb 3, 2023

@reta It is automated for the BWC version on the .x branch of the same major version (#6164) but seems to not look ahead to the next major version.

@reta
Copy link
Collaborator

reta commented Feb 3, 2023

@reta It is automated for the BWC version on the .x branch of the same major version (#6164) but seems to not look ahead to the next major version.

Oh I see, thanks @andrross

@andrross
Copy link
Member Author

andrross commented Feb 3, 2023

Actually, it is automated for the main branch when a 2.x version is added. Seems there's just this one case of patch release for the previous major version that isn't automated.

@reta
Copy link
Collaborator

reta commented Feb 3, 2023

@andrross do we need to bring this to 2.5 and main as well?

andrross added a commit to andrross/OpenSearch that referenced this pull request Feb 3, 2023
Signed-off-by: Andrew Ross <andrross@amazon.com>
@andrross
Copy link
Member Author

andrross commented Feb 3, 2023

2.5 yes (#6176). main no because it doesn't have any support for the 1.x versions.

andrross added a commit that referenced this pull request Feb 3, 2023
Signed-off-by: Andrew Ross <andrross@amazon.com>
Poojita-Raj added a commit to Poojita-Raj/OpenSearch that referenced this pull request Mar 7, 2023
Poojita-Raj added a commit to Poojita-Raj/OpenSearch that referenced this pull request Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants