-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change commit message and PR title to imperative mood #6177
Conversation
Signed-off-by: Andrew Ross <andrross@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad you did this on a Friday 😃
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-6177-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 61304a6a31cc2a0f722a867f515e5cb68d9050d6
# Push it to GitHub
git push --set-upstream origin backport/backport-6177-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x Then, create a pull request where the |
This backports both opensearch-project#2572 and opensearch-project#6177. This was created by doing: ``` git checkout upstream/main .github/workflows/version.yml ``` Signed-off-by: Andrew Ross <andrross@amazon.com>
Is it "Increment" or "Increments"? |
"Increment", per the guidance here: https://cbea.ms/git-commit/ The way I remember this is by referring to how git itself formulates messages for things like
|
@andrross I think I am thrown off by dependapot which keeps saying "bumps". We should fix it probably. |
Because I'm a pedant.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.