Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky segrep test testPrimaryStopped_ReplicaPromoted #6282

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

mch2
Copy link
Member

@mch2 mch2 commented Feb 10, 2023

Signed-off-by: Marc Handalian handalm@amazon.com

Description

Unmute segrep test testPrimaryStopped_ReplicaPromoted. This test was muted with PR: https://github.com/opensearch-project/OpenSearch/pull/5739/files# and fixed with #6015 that waits until replicas have done a sync until asserting doc count.

Issues Resolved

#5669

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2023

Codecov Report

Merging #6282 (639aa3f) into main (1f4cdd2) will decrease coverage by 0.06%.
The diff coverage is 39.10%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main    #6282      +/-   ##
============================================
- Coverage     70.72%   70.66%   -0.06%     
- Complexity    58791    58807      +16     
============================================
  Files          4782     4789       +7     
  Lines        281484   281788     +304     
  Branches      40642    40669      +27     
============================================
+ Hits         199072   199128      +56     
- Misses        65984    66299     +315     
+ Partials      16428    16361      -67     
Impacted Files Coverage Δ
...es/replication/SegmentReplicationStatsRequest.java 0.00% <0.00%> (ø)
...ication/SegmentReplicationStatsRequestBuilder.java 0.00% <0.00%> (ø)
.../org/opensearch/client/support/AbstractClient.java 31.76% <0.00%> (-0.54%) ⬇️
...java/org/opensearch/index/shard/StoreRecovery.java 66.36% <0.00%> (+0.61%) ⬆️
.../indices/replication/SegmentReplicationSource.java 100.00% <ø> (ø)
...cation/TransportSegmentReplicationStatsAction.java 11.11% <11.11%> (ø)
...s/replication/SegmentReplicationStatsResponse.java 13.33% <13.33%> (ø)
...h/indices/replication/SegmentReplicationState.java 46.96% <24.65%> (-31.98%) ⬇️
...s/replication/SegmentReplicationTargetService.java 50.00% <41.66%> (-0.72%) ⬇️
...ex/translog/transfer/TranslogTransferMetadata.java 91.83% <50.00%> (+2.74%) ⬆️
... and 507 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Marc Handalian <handalm@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@mch2
Copy link
Member Author

mch2 commented Feb 10, 2023

Gradle Check (Jenkins) Run Completed with:

#6251

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.gateway.RecoveryFromGatewayIT.testReuseInFileBasedPeerRecovery

@mch2 mch2 merged commit c95a6b9 into opensearch-project:main Feb 10, 2023
@mch2 mch2 deleted the flaky branch February 10, 2023 05:44
@mch2 mch2 added the backport 2.x Backport to 2.x branch label Feb 10, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 10, 2023
Signed-off-by: Marc Handalian <handalm@amazon.com>
(cherry picked from commit c95a6b9)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mch2 pushed a commit that referenced this pull request Feb 10, 2023
(cherry picked from commit c95a6b9)

Signed-off-by: Marc Handalian <handalm@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants