[Remote Store] Create empty lucene index during restore if remote segment store is empty #6375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sachin Kale <kalsac@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #6375 +/- ##
============================================
+ Coverage 70.67% 70.76% +0.08%
- Complexity 58958 59039 +81
============================================
Files 4799 4799
Lines 282432 282434 +2
Branches 40716 40717 +1
============================================
+ Hits 199622 199861 +239
+ Misses 66428 66190 -238
- Partials 16382 16383 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Running on local for a couple of hundred times before opening the PR for review. |
sachinpkale
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
adnapibar,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah and
xuezhou25
as code owners
ashking94
reviewed
Feb 20, 2023
| @@ -457,6 +457,9 @@ private void recoverFromRemoteStore(IndexShard indexShard, Repository repository | |||
| // Download segments from remote segment store | |||
| indexShard.syncSegmentsFromRemoteSegmentStore(true); | |||
|
|
|||
| if (store.directory().listAll().length == 0) { | |||
| store.createEmpty(indexShard.indexSettings().getIndexVersionCreated().luceneVersion); | |||
There was a problem hiding this comment.
[Question] Just wondering since the creation of empty directory depends on the lucene version, do we need to handle anything for version upgrade?
There was a problem hiding this comment.
It should not change anything in the version compatibility as the index already exists. I think the confusion is due to PR title. We are not creating a new OpenSearch index but empty lucene index :). Let me change the title.
sachinpkale
changed the title
gbbafna
approved these changes
Feb 20, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 20, 2023
Signed-off-by: Sachin Kale <kalsac@amazon.com> (cherry picked from commit 1904158) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gbbafna
pushed a commit
that referenced
this pull request
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.