[Backport 2.x] Segment Replication - Update /_cat/segment_replication API with backp… #6741

Poojita-Raj · 2023-03-17T19:33:25Z

…ressure metrics. (#6674)

Segment Replication - Update Segment Replication API with backpressure metrics.

This change updates the existing /_cat/segment_replication API to include backpressure metrics. It does this by returning stats from primary shards for its tracked replication group and merging it with metrics returned from replicas. Primary captured metrics will now appear by default, with replica per sync events showing when detailed=true is set.

PR Feedback.
Fixed current_lag header alias.

Description

Manual backport, rebased.

Issues Resolved

Resolves #4478

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff
Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…ressure metrics. (opensearch-project#6674) * Segment Replication - Update Segment Replication API with backpressure metrics. This change updates the existing /_cat/segment_replication API to include backpressure metrics. It does this by returning stats from primary shards for its tracked replication group and merging it with metrics returned from replicas. Primary captured metrics will now appear by default, with replica per sync events showing when detailed=true is set. Signed-off-by: Marc Handalian <handalm@amazon.com> * PR Feedback. Signed-off-by: Marc Handalian <handalm@amazon.com> * Fixed current_lag header alias. Signed-off-by: Marc Handalian <handalm@amazon.com> --------- Signed-off-by: Marc Handalian <handalm@amazon.com>

github-actions · 2023-03-17T19:59:16Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/12603/
CommitID: abe1ac8
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

Rishikesh1159 · 2023-03-17T20:05:41Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌

URL: https://build.ci.opensearch.org/job/gradle-check/12603/

CommitID: abe1ac8
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

REPRODUCE WITH: ./gradlew ':server:internalClusterTest' --tests "org.opensearch.snapshots.SearchableSnapshotIT.testPruneFileCacheOnIndexDeletion" -Dtests.seed=BC8DED9028DD8814 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=fr-CA -Dtests.timezone=Canada/Saskatchewan -Druntime.java=17

org.opensearch.snapshots.SearchableSnapshotIT > testPruneFileCacheOnIndexDeletion FAILED
    java.lang.AssertionError: timed out waiting for green state
        at __randomizedtesting.SeedInfo.seed([BC8DED9028DD8814:64E504583C56F5B5]:0)
        at org.junit.Assert.fail(Assert.java:89)
        at org.opensearch.test.OpenSearchIntegTestCase.ensureColor(OpenSearchIntegTestCase.java:1007)
        at org.opensearch.test.OpenSearchIntegTestCase.ensureGreen(OpenSearchIntegTestCase.java:938)
        at org.opensearch.test.OpenSearchIntegTestCase.ensureGreen(OpenSearchIntegTestCase.java:927)
        at org.opensearch.snapshots.SearchableSnapshotIT.createIndexWithDocsAndEnsureGreen(SearchableSnapshotIT.java:279)
        at org.opensearch.snapshots.SearchableSnapshotIT.testPruneFileCacheOnIndexDeletion(SearchableSnapshotIT.java:534)

Gradle check failure unrelated to this PR. Issue already opened for failure:#6738

github-actions · 2023-03-17T20:30:33Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/12605/
CommitID: abe1ac8
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

Poojita-Raj · 2023-03-17T20:49:36Z

Gradle Check (Jenkins) Run Completed with:

* **RESULT:** FAILURE ❌

* **URL:** https://build.ci.opensearch.org/job/gradle-check/12605/

* **CommitID:** [abe1ac8](https://github.com/opensearch-project/OpenSearch/commit/abe1ac813bee99203138ceb86e0f6463bbb91420)
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure [a flaky test](https://github.com/opensearch-project/OpenSearch/blob/main/DEVELOPER_GUIDE.md#flaky-tests) unrelated to your change?

Failing tests:
org.opensearch.repositories.azure.AzureBlobStoreRepositoryTests
org.opensearch.indices.replication.SegmentReplicationAllocationIT

Both suites are known flaky tests.

github-actions · 2023-03-17T21:05:53Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/12606/
CommitID: abe1ac8
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-03-17T21:37:53Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/12608/
CommitID: abe1ac8
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-03-17T23:05:49Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/12610/
CommitID: abe1ac8
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

Poojita-Raj · 2023-03-17T23:21:24Z

known flaky test: #6287 org.opensearch.cluster.shards.ClusterShardLimitIT.testCreateIndexWithMaxClusterShardSetting

github-actions · 2023-03-17T23:56:41Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❕
TEST FAILURES:

      1 org.opensearch.indices.replication.SegmentReplicationRelocationIT.testFlushAfterRelocation

URL: https://build.ci.opensearch.org/job/gradle-check/12614/
CommitID: abe1ac8
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

codecov-commenter · 2023-03-17T23:58:41Z

Codecov Report

Merging #6741 (abe1ac8) into 2.x (70707fe) will decrease coverage by 0.05%.
The diff coverage is 30.21%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##                2.x    #6741      +/-   ##
============================================
- Coverage     70.49%   70.45%   -0.05%     
+ Complexity    59517    59434      -83     
============================================
  Files          4805     4806       +1     
  Lines        285248   285295      +47     
  Branches      41467    41472       +5     
============================================
- Hits         201086   200996      -90     
- Misses        67448    67555     +107     
- Partials      16714    16744      +30

Impacted Files	Coverage Δ
...lication/SegmentReplicationShardStatsResponse.java	`0.00% <0.00%> (ø)`
...earch/index/SegmentReplicationPressureService.java	`80.00% <0.00%> (-1.64%)`	⬇️
...org/opensearch/index/seqno/ReplicationTracker.java	`68.38% <ø> (+0.10%)`	⬆️
...cation/TransportSegmentReplicationStatsAction.java	`9.80% <3.03%> (-1.01%)`	⬇️
...s/replication/SegmentReplicationStatsResponse.java	`13.79% <22.22%> (+0.45%)`	⬆️
...opensearch/index/SegmentReplicationShardStats.java	`36.58% <33.33%> (+4.23%)`	⬆️
...st/action/cat/RestCatSegmentReplicationAction.java	`45.09% <47.27%> (-5.93%)`	⬇️
...nsearch/index/SegmentReplicationPerGroupStats.java	`32.00% <60.00%> (+3.42%)`	⬆️
.../org/opensearch/index/SegmentReplicationStats.java	`15.38% <100.00%> (ø)`
...ensearch/index/SegmentReplicationStatsTracker.java	`95.45% <100.00%> (+0.21%)`	⬆️

... and 502 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Poojita-Raj requested review from reta, anasalkouz, andrross, Bukhtawar, CEHENKLE, dblock, gbbafna, setiah, kartg, kotwanikunal, mch2, nknize, owaiskazi19, Rishikesh1159, ryanbogan, saratvemulapalli, shwetathareja, dreamer-89, tlfeng, VachaShah and xuezhou25 as code owners March 17, 2023 19:33

Poojita-Raj changed the title ~~Segment Replication - Update /_cat/segment_replication API with backp…~~ [Backport 2.x] Segment Replication - Update /_cat/segment_replication API with backp… Mar 17, 2023

Poojita-Raj added the skip-changelog label Mar 17, 2023

Rishikesh1159 mentioned this pull request Mar 17, 2023

[BUG] org.opensearch.snapshots.SearchableSnapshotIT.testPruneFileCacheOnIndexDeletion is flaky #6738

Closed

Rishikesh1159 approved these changes Mar 18, 2023

View reviewed changes

Rishikesh1159 merged commit f8f4cc6 into opensearch-project:2.x Mar 18, 2023

Rishikesh1159 mentioned this pull request Mar 18, 2023

[Backport 2.x] Segment Replication - Update /_cat/segment_replication API with backpressure metrics. (#6674) #6727

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Backport 2.x] Segment Replication - Update /_cat/segment_replication API with backp… #6741

[Backport 2.x] Segment Replication - Update /_cat/segment_replication API with backp… #6741

Poojita-Raj commented Mar 17, 2023 •

edited by Rishikesh1159

Loading

github-actions bot commented Mar 17, 2023

Rishikesh1159 commented Mar 17, 2023 •

edited

Loading

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Mar 17, 2023

Poojita-Raj commented Mar 17, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Mar 17, 2023

github-actions bot commented Mar 17, 2023

github-actions bot commented Mar 17, 2023

Poojita-Raj commented Mar 17, 2023

github-actions bot commented Mar 17, 2023

codecov-commenter commented Mar 17, 2023

[Backport 2.x] Segment Replication - Update /_cat/segment_replication API with backp… #6741

[Backport 2.x] Segment Replication - Update /_cat/segment_replication API with backp… #6741

Conversation

Poojita-Raj commented Mar 17, 2023 • edited by Rishikesh1159 Loading

Description

Issues Resolved

Check List

github-actions bot commented Mar 17, 2023

Gradle Check (Jenkins) Run Completed with:

Rishikesh1159 commented Mar 17, 2023 • edited Loading

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Mar 17, 2023

Gradle Check (Jenkins) Run Completed with:

Poojita-Raj commented Mar 17, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Mar 17, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Mar 17, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Mar 17, 2023

Gradle Check (Jenkins) Run Completed with:

Poojita-Raj commented Mar 17, 2023

github-actions bot commented Mar 17, 2023

Gradle Check (Jenkins) Run Completed with:

codecov-commenter commented Mar 17, 2023

Codecov Report

Poojita-Raj commented Mar 17, 2023 •

edited by Rishikesh1159

Loading

Rishikesh1159 commented Mar 17, 2023 •

edited

Loading