[Extensions] Moving ExtensionsRequest to use Protobuf #6960

saratvemulapalli · 2023-04-04T00:09:23Z

Description

As part of opensearch-project/opensearch-sdk-java#337. Moving the first API to protobuf to have seamless version support.

Issues Resolved

Part of #opensearch-project/opensearch-sdk-java#642
Also first introduction of protobuf #6844

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff
Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>

github-actions · 2023-04-04T00:20:34Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/13341/
CommitID: f1940e0
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-04-04T00:24:53Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/13343/
CommitID: 49a937a
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-04-04T00:30:41Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/13339/
CommitID: 4b4c9e2
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

saratvemulapalli · 2023-04-20T22:12:11Z

@reta @owaiskazi19 @peternied @VachaShah sorry couldn't get back to this since a week. The change is now ready for review. Everything works :)

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>

reta · 2023-04-20T22:17:51Z

server/build.gradle

@@ -45,6 +48,13 @@ publishing {

 archivesBaseName = 'opensearch'

+sourceSets {
+  main {


reta · 2023-04-20T22:18:24Z

server/build.gradle

@@ -315,13 +344,34 @@ tasks.named("dependencyLicenses").configure {
    }
 }

+tasks.named("missingJavadoc").configure {


reta · 2023-04-20T22:22:47Z

Nice one @saratvemulapalli , pretty clean and simple

owaiskazi19

Overall LGTM! Thanks for addressing the feedback @saratvemulapalli! Do you think we should add tests for the generated Protobuf classes?

server/build.gradle

github-actions · 2023-04-20T22:47:20Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❕
TEST FAILURES:

      1 org.opensearch.indices.replication.SegmentReplicationIT.testScrollWithOngoingSegmentReplication

URL: https://build.ci.opensearch.org/job/gradle-check/14392/
CommitID: 84019a7
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

github-actions · 2023-04-20T22:49:16Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❕
TEST FAILURES:

      1 org.opensearch.indices.replication.SegmentReplicationIT.testScrollCreatedOnReplica
      1 org.opensearch.cluster.allocation.AwarenessAllocationIT.testThreeZoneOneReplicaWithForceZoneValueAndLoadAwareness

URL: https://build.ci.opensearch.org/job/gradle-check/14393/
CommitID: b71ec29
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>

github-actions · 2023-04-20T23:50:24Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/14394/
CommitID: 33e500a
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

saratvemulapalli · 2023-04-20T23:55:16Z

Overall LGTM! Thanks for addressing the feedback @saratvemulapalli! Do you think we should add tests for the generated Protobuf classes?

Tests for generated classes, I am like "protoc" can you generate unit tests too :D.
Anyway for generated code its already concise and optimized, no point writing tests for message data types/for internal protobuf business logic.
@reta WDYT ?

saratvemulapalli · 2023-04-20T23:55:47Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌

URL: https://build.ci.opensearch.org/job/gradle-check/14394/

CommitID: 33e500a
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

Looks like 2.7 is on its way, i'll rebase my PR.

 [2.6.1] build complete, generating: /var/jenkins/workspace/gradle-check/search/distribution/bwc/bugfix/build/bwc/checkout-2.6/build/14394.tar.bz2
 [2.6.1] 
 [2.6.1] BUILD SUCCESSFUL in 5m 9s
 [2.6.1] 165 actionable tasks: 165 executed

> Task :distribution:bwc:minor:buildBwcLinuxTar
 [2.8.0] > Task :distribution:archives:buildLinuxTar
 [2.8.0] > Task :distribution:archives:linux-tar:assemble
 [2.8.0] build complete, generating: /var/jenkins/workspace/gradle-check/search/distribution/bwc/minor/build/bwc/checkout-2.x/build/14394.tar.bz2

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>

github-actions · 2023-04-21T00:34:20Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/14395/
CommitID: 1089388

VachaShah

This looks great!

opensearch-trigger-bot · 2023-04-21T01:16:24Z

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-6960-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c0f7c192baa574407d9d081343fd6318c092cbc5
# Push it to GitHub
git push --set-upstream origin backport/backport-6960-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-6960-to-2.x.

…ject#6960) Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>

…ject#6960)

…ject#6960) Signed-off-by: Shivansh Arora <hishiv@amazon.com>

saratvemulapalli added 4 commits April 3, 2023 13:59

Moving ExtensionRequest to Proto

6ed4085

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>

Adding spotless changes

6c0f1a2

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>

Fixing licenses

65dfbb9

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>

Fixing precommit

4b4c9e2

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>

saratvemulapalli requested review from reta, anasalkouz, andrross, Bukhtawar, CEHENKLE, dblock, gbbafna, setiah, kartg, kotwanikunal, mch2, nknize, owaiskazi19, Rishikesh1159, ryanbogan, shwetathareja, dreamer-89, tlfeng, VachaShah and xuezhou25 as code owners April 4, 2023 00:09

saratvemulapalli added 2 commits April 3, 2023 17:13

Adding Changelog

f1940e0

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>

Removing old implementation

49a937a

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>

saratvemulapalli mentioned this pull request Apr 4, 2023

Companion changes for moving ExtensionRequest to Protobuf opensearch-project/opensearch-sdk-java#647

Merged

saratvemulapalli requested review from reta, VachaShah and owaiskazi19 April 20, 2023 22:12

Moving to central versioning

b71ec29

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>

reta reviewed Apr 20, 2023

View reviewed changes

server/build.gradle

@@ -45,6 +48,13 @@ publishing {

archivesBaseName = 'opensearch'

sourceSets {

main {

Copy link

Collaborator

reta Apr 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

reta reviewed Apr 20, 2023

View reviewed changes

owaiskazi19 reviewed Apr 20, 2023

View reviewed changes

server/build.gradle Outdated Show resolved Hide resolved

server/build.gradle Show resolved Hide resolved

saratvemulapalli mentioned this pull request Apr 20, 2023

MissingJavaDoc checker to support * for ignoring group of files #7264

Closed

Addressing comments

33e500a

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>

Removing thirdpartyaudit from hdfs

1089388

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>

VachaShah approved these changes Apr 21, 2023

View reviewed changes

saratvemulapalli merged commit c0f7c19 into opensearch-project:main Apr 21, 2023

saratvemulapalli added backport 2.x Backport to 2.x branch extensions labels Apr 21, 2023

saratvemulapalli deleted the extensionRequestv1 branch April 21, 2023 01:26

saratvemulapalli added a commit to saratvemulapalli/OpenSearch that referenced this pull request Apr 21, 2023

[Extensions] Moving ExtensionsRequest to use Protobuf (opensearch-pro…

29b8a4b

…ject#6960) Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>

saratvemulapalli mentioned this pull request Apr 21, 2023

[Backport 2.x] Moving ExtensionsRequest to use Protobuf #7265

Merged

6 tasks

austintlee pushed a commit to austintlee/OpenSearch that referenced this pull request Apr 28, 2023

[Extensions] Moving ExtensionsRequest to use Protobuf (opensearch-pro…

ad8e5ac

…ject#6960)

dbwiddis mentioned this pull request Aug 13, 2023

[BUG] Empty protobuf-java-NOTICE.txt file in project root #9287

Closed

dbwiddis mentioned this pull request Sep 15, 2023

Introduce protobuf serialization/deserialization support for transport requests/responses #9737

Closed

6 tasks

shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024

[Extensions] Moving ExtensionsRequest to use Protobuf (opensearch-pro…

5153c45

…ject#6960) Signed-off-by: Shivansh Arora <hishiv@amazon.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Extensions] Moving ExtensionsRequest to use Protobuf #6960

[Extensions] Moving ExtensionsRequest to use Protobuf #6960

saratvemulapalli commented Apr 4, 2023 •

edited

Loading

github-actions bot commented Apr 4, 2023

github-actions bot commented Apr 4, 2023

github-actions bot commented Apr 4, 2023

saratvemulapalli commented Apr 20, 2023 •

edited

Loading

reta Apr 20, 2023

reta Apr 20, 2023

reta commented Apr 20, 2023

owaiskazi19 left a comment •

edited

Loading

github-actions bot commented Apr 20, 2023

github-actions bot commented Apr 20, 2023

github-actions bot commented Apr 20, 2023

saratvemulapalli commented Apr 20, 2023

saratvemulapalli commented Apr 20, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Apr 21, 2023

VachaShah left a comment

opensearch-trigger-bot bot commented Apr 21, 2023

[Extensions] Moving ExtensionsRequest to use Protobuf #6960

[Extensions] Moving ExtensionsRequest to use Protobuf #6960

Conversation

saratvemulapalli commented Apr 4, 2023 • edited Loading

Description

Issues Resolved

Check List

github-actions bot commented Apr 4, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Apr 4, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Apr 4, 2023

Gradle Check (Jenkins) Run Completed with:

saratvemulapalli commented Apr 20, 2023 • edited Loading

reta Apr 20, 2023

Choose a reason for hiding this comment

reta Apr 20, 2023

Choose a reason for hiding this comment

reta commented Apr 20, 2023

owaiskazi19 left a comment • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Apr 20, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Apr 20, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Apr 20, 2023

Gradle Check (Jenkins) Run Completed with:

saratvemulapalli commented Apr 20, 2023

saratvemulapalli commented Apr 20, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Apr 21, 2023

Gradle Check (Jenkins) Run Completed with:

VachaShah left a comment

Choose a reason for hiding this comment

opensearch-trigger-bot bot commented Apr 21, 2023

saratvemulapalli commented Apr 4, 2023 •

edited

Loading

saratvemulapalli commented Apr 20, 2023 •

edited

Loading

owaiskazi19 left a comment •

edited

Loading