-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Remote Store] Support to emit multiple streams for a file content each responsible for processing a specific part of the file #7000
Conversation
Gradle Check (Jenkins) Run Completed with:
|
Tagging @elfisher @muralikpbhat @reta @mch2 @dreamer-89 @andrross @Bukhtawar @sachinpkale @itiyamas @dblock @shwetathareja @saratvemulapalli @ashking94 for review. Please tag others who can review this as well. |
25951f9
to
68fb8d7
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
68fb8d7
to
29b6dca
Compare
server/src/main/java/org/opensearch/common/blobstore/stream/write/WriteContext.java
Show resolved
Hide resolved
server/src/main/java/org/opensearch/common/blobstore/transfer/RemoteTransferContainer.java
Show resolved
Hide resolved
server/src/main/java/org/opensearch/common/blobstore/stream/write/WritePriority.java
Show resolved
Hide resolved
server/src/main/java/org/opensearch/common/blobstore/transfer/RemoteTransferContainer.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some containers look unwieldy and due to missing usage(in some case tests like WriteContext) doesn't give a good understanding on how this is originally designed to be consumed
Gradle Check (Jenkins) Run Completed with:
|
server/src/main/java/org/opensearch/common/blobstore/transfer/RemoteTransferContainer.java
Outdated
Show resolved
Hide resolved
…for processing a specific part of the file Signed-off-by: Raghuvansh Raj <raghraaj@amazon.com>
Signed-off-by: Raghuvansh Raj <raghraaj@amazon.com>
Signed-off-by: Raghuvansh Raj <raghraaj@amazon.com>
Signed-off-by: Raghuvansh Raj <raghraaj@amazon.com>
Signed-off-by: Raghuvansh Raj <raghraaj@amazon.com>
Signed-off-by: Raghuvansh Raj <raghraaj@amazon.com>
1e83814
to
6b2335c
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Raghuvansh Raj <raghraaj@amazon.com>
281d895
to
b6e902d
Compare
Gradle Check (Jenkins) Run Completed with:
|
…ch responsible for processing a specific part of the file (#7000) * Support to emit multiple streams for a file content each responsible for processing a specific part of the file Signed-off-by: Raghuvansh Raj <raghraaj@amazon.com> (cherry picked from commit 0c1a29a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ch responsible for processing a specific part of the file (#7000) (#7983) * Support to emit multiple streams for a file content each responsible for processing a specific part of the file (cherry picked from commit 0c1a29a) Signed-off-by: Raghuvansh Raj <raghraaj@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ch responsible for processing a specific part of the file (opensearch-project#7000) (opensearch-project#7983) * Support to emit multiple streams for a file content each responsible for processing a specific part of the file (cherry picked from commit 0c1a29a) Signed-off-by: Raghuvansh Raj <raghraaj@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ch responsible for processing a specific part of the file (opensearch-project#7000) * Support to emit multiple streams for a file content each responsible for processing a specific part of the file Signed-off-by: Raghuvansh Raj <raghraaj@amazon.com> Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
…ch responsible for processing a specific part of the file (opensearch-project#7000) * Support to emit multiple streams for a file content each responsible for processing a specific part of the file Signed-off-by: Raghuvansh Raj <raghraaj@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Credits: @vikasvb90 and @itiyamas for the design and core implementations of the feature.
Description
InputStream
extensions to emit stream from a specific part of a file, which starts reading from a specific position and ensures that maximum length of content read doesn't exceed a specified limit.OffsetRangeFileInputStream
achieves this for File objects, whileOffsetRangeIndexInputStream
achieves this for lucene's IndexInput constructRemoteTransferContainer
has utilities to open streams to specific parts of the file based on the type as mentioned in the previous point. It also manages post upload tasks by implementing anUploadFinalizer
.ResettableCheckedInputStream
allows for individual parts to be reset through mark and reset in the event of upload failuresIssues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.