Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Segment Replication] Benchmark commits on replica #7124

Closed

Conversation

dreamer-89
Copy link
Member

@dreamer-89 dreamer-89 commented Apr 12, 2023

Description

Benchmark commits on replica for segment replication enabled indices. Sample benchmark result

Benchmark                                                 Mode  Cnt    Score   Error  Units
NRTReplicationEngineBenchmark.testCommit_10000Docs        avgt    2  322.832          ms/op
NRTReplicationEngineBenchmark.testCommit_1000Docs         avgt    2  220.508          ms/op
NRTReplicationEngineBenchmark.testCommit_100Docs          avgt    2  216.975          ms/op
NRTReplicationEngineBenchmark.testCommit_10Docs           avgt    2  654.693          ms/op
NRTReplicationEngineBenchmark.testCommit_With_ForceMerge  avgt    2  612.419          ms/op

Issues Related

#7043

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: Suraj Singh <surajrider@gmail.com>
@nknize
Copy link
Collaborator

nknize commented Apr 12, 2023

@dreamer-89 have you run this with JFR yet? Can you put the numbers in the description?

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

Codecov Report

Merging #7124 (70313d0) into main (b4e361c) will increase coverage by 0.01%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main    #7124      +/-   ##
============================================
+ Coverage     70.59%   70.61%   +0.01%     
- Complexity    59406    59466      +60     
============================================
  Files          4852     4853       +1     
  Lines        285127   285233     +106     
  Branches      41104    41109       +5     
============================================
+ Hits         201292   201419     +127     
+ Misses        67316    67277      -39     
- Partials      16519    16537      +18     
Impacted Files Coverage Δ
...enchmark/engine/NRTReplicationEngineBenchmark.java 0.00% <0.00%> (ø)

... and 478 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dreamer-89
Copy link
Member Author

dreamer-89 commented Apr 12, 2023

@dreamer-89 have you run this with JFR yet? Can you put the numbers in the description?

Thank you @nknize for the comment. No, I haven't yet tried JFR (Java Flight Recorder). Based on your comment, will try it now and upload the results.

Converting to draft for now.

@dreamer-89 dreamer-89 marked this pull request as draft April 12, 2023 19:37
@dreamer-89 dreamer-89 added feedback needed Issue or PR needs feedback benchmarking Issues related to benchmarking or performance. labels Apr 12, 2023
@dreamer-89
Copy link
Member Author

dreamer-89 commented Apr 14, 2023

Will come back to this issue once done with #6761 which is more pressing for GA release. Will it in draft state.
CC @mch2 @nknize

@opensearch-trigger-bot
Copy link
Contributor

This PR is stalled because it has been open for 30 days with no activity. Remove stalled label or comment or this will be closed in 7 days.

@opensearch-trigger-bot opensearch-trigger-bot bot added the stalled Issues that have stalled label Jun 23, 2023
@opensearch-trigger-bot
Copy link
Contributor

This PR was closed because it has been stalled for 7 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmarking Issues related to benchmarking or performance. feedback needed Issue or PR needs feedback skip-changelog stalled Issues that have stalled
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants