[CCI] [BUG] Fixing extension settings update consumers

[Kuanysh-kst]

Description

added equals to the method to remove the bug, which appears in the addSettingsUpdateConsumer() method

Related Issues

opensearch-project/opensearch-sdk-java#366

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/14987/
• CommitID: b4347ce
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[dblock]

@Kuanysh-kst Thanks. Care to describe what you're fixing? Add a unit test please.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/15261/
• CommitID: de93caa
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/15327/
• CommitID: 5c36308
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/18068/
• CommitID: b335b84
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/18069/
• CommitID: adfeca8
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[dbwiddis]

Gradle check failure unrelated to this PR:

• What went wrong:
  Execution failed for task ':distribution:bwc:minor:buildBwcLinuxTar'.

Building 2.8.0 didn't generate expected file /var/jenkins/workspace/gradle-check/search/distribution/bwc/minor/build/bwc/checkout-2.x/distribution/archives/linux-tar/build/distributions/opensearch-min-2.8.0-SNAPSHOT-linux-x64.tar.gz

[dbwiddis]

Looks similar to #7396

@Kuanysh-kst can you try to rebase your branch? I think that'll fix the gradle check.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/18102/
• CommitID: 4ad38c9
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/18104/
• CommitID: adfeca8
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/18105/
• CommitID: c3cff5c
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[dbwiddis]

@Kuanysh-kst Good news, tests are running. Bad news, test failure:

java.lang.AssertionError: expected:<false> but was:<true>
at org.opensearch.extensions.ExtensionsManagerTests.testHandleAddSettingsUpdateConsumerRequest(ExtensionsManagerTests.java:785)

That's this line:

        // Should fail as component settings are not registered within cluster settings
        assertEquals(false, ((AcknowledgedResponse) response).getStatus());

The code changes status to false on exception, but doesn't do anything in the case that the setting is not registered (node or index scope) which this PR has turned into a no-op.

This seems correlated with this comment saying we should do a null check (and we don't):

// do a null check and throw IllegalArgument exception here if neither index or node scope

Suggested fix:

1. Do the null check on settingForUpdateConsumer right below that comment line.
2. Throw an illegal argument exception stating the reason for the exception (not index or node scope)
3. Add IllegalArgumentException as one of the caught exceptions in the catch block in addition to the SettingsException

Need to fix tests

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.action.admin.cluster.node.tasks.ResourceAwareTasksTests.testBasicTaskResourceTracking

• URL: https://build.ci.opensearch.org/job/gradle-check/18113/
• CommitID: fc3cda7
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[codecov]

Codecov Report

Merging #7456 (fc3cda7) into main (68c1c86) will decrease coverage by 0.01%.
The diff coverage is 19.04%.

@@             Coverage Diff              @@
##               main    #7456      +/-   ##
============================================
- Coverage     70.93%   70.93%   -0.01%     
+ Complexity    56636    56614      -22     
============================================
  Files          4719     4719              
  Lines        267559   267574      +15     
  Branches      39206    39211       +5     
============================================
- Hits         189805   189798       -7     
- Misses        61714    61730      +16     
- Partials      16040    16046       +6     

Impacted Files	Coverage Δ
...a/org/opensearch/extensions/ExtensionsManager.java	57.07% <ø> (ø)
...sions/AddSettingsUpdateConsumerRequestHandler.java	44.73% <19.04%> (-20.49%)	⬇️

... and 489 files with indirect coverage changes

[dbwiddis]

Added opensearch-project/opensearch-sdk-java#835 to follow up with SDK integration tests for the lines called out by codecov.

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-7456-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 cc67469292bc8d5be1b476fb0fb11e07fe82f8a6
# Push it to GitHub
git push --set-upstream origin backport/backport-7456-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-7456-to-2.x.