-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Remote Store] Deletion of Remote Segments and Translog upon Index Deletion #7682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
sachinpkale
reviewed
Jun 5, 2023
Overall changes LGTM |
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
gbbafna
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah and
dbwiddis
as code owners
June 6, 2023 05:15
Bukhtawar
reviewed
Jun 12, 2023
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Bukhtawar
reviewed
Jun 13, 2023
sachinpkale
approved these changes
Jun 14, 2023
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-7682-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 bf3cf7134447ae1cdfbef51e5bbf2bfae44290b8
# Push it to GitHub
git push --set-upstream origin backport/backport-7682-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x Then, create a pull request where the |
gaiksaya
pushed a commit
to gaiksaya/OpenSearch
that referenced
this pull request
Jun 15, 2023
…letion (opensearch-project#7682) Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
gbbafna
added a commit
to gbbafna/OpenSearch
that referenced
this pull request
Jun 15, 2023
…letion (opensearch-project#7682) Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
6 tasks
gbbafna
added a commit
to gbbafna/OpenSearch
that referenced
this pull request
Jun 19, 2023
…letion (opensearch-project#7682) Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
sachinpkale
pushed a commit
that referenced
this pull request
Jun 19, 2023
… upon Index De… (#8073) * [Remote Store] Deletion of Remote Segments and Translog upon Index Deletion (#7682) Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> * Translog deletion only for remote txlog enabled indices Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> --------- Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
gaiksaya
pushed a commit
to gaiksaya/OpenSearch
that referenced
this pull request
Jun 26, 2023
… upon Index De… (opensearch-project#8073) * [Remote Store] Deletion of Remote Segments and Translog upon Index Deletion (opensearch-project#7682) Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> * Translog deletion only for remote txlog enabled indices Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> --------- Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
imRishN
pushed a commit
to imRishN/OpenSearch
that referenced
this pull request
Jun 27, 2023
…letion (opensearch-project#7682) Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
shiv0408
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Apr 25, 2024
…letion (opensearch-project#7682) Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upon Index deletion, we delete Remote Translog and delete files in Remote Segments which are not referenced by any snapshots.
ToDo
Index level folders are still not deleted . We are only cleaning shard level folders in this change . Will be creating an issue for same.
Make Remote Segment Deletion Async - Current implementation will increase index deletion time . But we already plan to make it async .
Related Issues
Resolves #3511
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.