Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @sachinpkale as an OpenSearch maintainer #8019

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

andrross
Copy link
Member

I have nominated and maintainers have agreed to invite Sachin Kale (@sachinpkale) to be a co-maintainer. Sachin has kindly accepted.

Sachin has led the design and implementation of the remote backed storage feature in OpenSearch. This feature was introduced as experimental in OpenSearch 2.3 and is planned for general availability in 2.9. Some significant issues and PRs authored by Sachin for this effort are as follows:

Feature proposal: #1968
Upload segments to remote store post refresh: #3460
Add rest endpoint for remote store restore: #3576
Add RemoteSegmentStoreDirectory to interact with remote segment store: #4020

In total, Sachin has authored 57 PRs going back to May 2022. He also frequently reviews contributions from others and has reviewed nearly 100 PRs in the same time frame.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@andrross andrross added the backport 2.x Backport to 2.x branch label Jun 12, 2023
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.search.backpressure.SearchBackpressureIT.testSearchShardTaskCancellationWithHighCpu
      1 org.opensearch.remotestore.RemoteStoreRefreshListenerIT.testRemoteRefreshRetryOnFailure

@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #8019 (9143090) into main (5c32256) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #8019      +/-   ##
============================================
- Coverage     70.88%   70.85%   -0.04%     
- Complexity    56561    56572      +11     
============================================
  Files          4719     4719              
  Lines        267446   267446              
  Branches      39210    39210              
============================================
- Hits         189582   189498      -84     
- Misses        61873    61926      +53     
- Partials      15991    16022      +31     

see 462 files with indirect coverage changes

@reta
Copy link
Collaborator

reta commented Jun 12, 2023

CODEOWNERS will be changed separately?

I have nominated and maintainers have agreed to invite Sachin Kale
(@sachinpkale) to be a co-maintainer. Sachin has kindly accepted.

Sachin has led the design and implementation of the remote backed
storage feature in OpenSearch. This feature was introduced as
experimental in OpenSearch 2.3 and is planned for general availability
in 2.9. Some significant issues and PRs authored by Sachin for this
effort are as follows:

Feature proposal: opensearch-project#1968
Upload segments to remote store post refresh: opensearch-project#3460
Add rest endpoint for remote store restore: opensearch-project#3576
Add RemoteSegmentStoreDirectory to interact with remote segment store: opensearch-project#4020

In total, Sachin has authored 57 PRs going back to May 2022. He also
frequently reviews contributions from others and has reviewed nearly 100
PRs in the same time frame.

Signed-off-by: Andrew Ross <andrross@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@andrross
Copy link
Member Author

CODEOWNERS will be changed separately?

I missed that! Updated the PR.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.search.backpressure.SearchBackpressureIT.testSearchTaskCancellationWithHighCpu
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testCancelPrimaryAllocation

@gaiksaya
Copy link
Member

Permissions are updated now:
image

@kotwanikunal kotwanikunal merged commit c45073c into opensearch-project:main Jun 12, 2023
@andrross andrross deleted the sachin-maintainer branch June 12, 2023 23:14
@andrross andrross added backport 2.x Backport to 2.x branch and removed backport 2.x Backport to 2.x branch labels Jun 13, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-8019-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c45073c2e8c8eb850f707fae2adf3ca37c08c896
# Push it to GitHub
git push --set-upstream origin backport/backport-8019-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-8019-to-2.x.

andrross added a commit to andrross/OpenSearch that referenced this pull request Jun 13, 2023
I have nominated and maintainers have agreed to invite Sachin Kale
(@sachinpkale) to be a co-maintainer. Sachin has kindly accepted.

Sachin has led the design and implementation of the remote backed
storage feature in OpenSearch. This feature was introduced as
experimental in OpenSearch 2.3 and is planned for general availability
in 2.9. Some significant issues and PRs authored by Sachin for this
effort are as follows:

Feature proposal: opensearch-project#1968
Upload segments to remote store post refresh: opensearch-project#3460
Add rest endpoint for remote store restore: opensearch-project#3576
Add RemoteSegmentStoreDirectory to interact with remote segment store: opensearch-project#4020

In total, Sachin has authored 57 PRs going back to May 2022. He also
frequently reviews contributions from others and has reviewed nearly 100
PRs in the same time frame.

Signed-off-by: Andrew Ross <andrross@amazon.com>
saratvemulapalli pushed a commit that referenced this pull request Jun 13, 2023
I have nominated and maintainers have agreed to invite Sachin Kale
(@sachinpkale) to be a co-maintainer. Sachin has kindly accepted.

Sachin has led the design and implementation of the remote backed
storage feature in OpenSearch. This feature was introduced as
experimental in OpenSearch 2.3 and is planned for general availability
in 2.9. Some significant issues and PRs authored by Sachin for this
effort are as follows:

Feature proposal: #1968
Upload segments to remote store post refresh: #3460
Add rest endpoint for remote store restore: #3576
Add RemoteSegmentStoreDirectory to interact with remote segment store: #4020

In total, Sachin has authored 57 PRs going back to May 2022. He also
frequently reviews contributions from others and has reviewed nearly 100
PRs in the same time frame.

Signed-off-by: Andrew Ross <andrross@amazon.com>
gaiksaya pushed a commit to gaiksaya/OpenSearch that referenced this pull request Jun 26, 2023
opensearch-project#8047)

I have nominated and maintainers have agreed to invite Sachin Kale
(@sachinpkale) to be a co-maintainer. Sachin has kindly accepted.

Sachin has led the design and implementation of the remote backed
storage feature in OpenSearch. This feature was introduced as
experimental in OpenSearch 2.3 and is planned for general availability
in 2.9. Some significant issues and PRs authored by Sachin for this
effort are as follows:

Feature proposal: opensearch-project#1968
Upload segments to remote store post refresh: opensearch-project#3460
Add rest endpoint for remote store restore: opensearch-project#3576
Add RemoteSegmentStoreDirectory to interact with remote segment store: opensearch-project#4020

In total, Sachin has authored 57 PRs going back to May 2022. He also
frequently reviews contributions from others and has reviewed nearly 100
PRs in the same time frame.

Signed-off-by: Andrew Ross <andrross@amazon.com>
imRishN pushed a commit to imRishN/OpenSearch that referenced this pull request Jun 27, 2023
I have nominated and maintainers have agreed to invite Sachin Kale
(@sachinpkale) to be a co-maintainer. Sachin has kindly accepted.

Sachin has led the design and implementation of the remote backed
storage feature in OpenSearch. This feature was introduced as
experimental in OpenSearch 2.3 and is planned for general availability
in 2.9. Some significant issues and PRs authored by Sachin for this
effort are as follows:

Feature proposal: opensearch-project#1968
Upload segments to remote store post refresh: opensearch-project#3460
Add rest endpoint for remote store restore: opensearch-project#3576
Add RemoteSegmentStoreDirectory to interact with remote segment store: opensearch-project#4020

In total, Sachin has authored 57 PRs going back to May 2022. He also
frequently reviews contributions from others and has reviewed nearly 100
PRs in the same time frame.

Signed-off-by: Andrew Ross <andrross@amazon.com>
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
I have nominated and maintainers have agreed to invite Sachin Kale
(@sachinpkale) to be a co-maintainer. Sachin has kindly accepted.

Sachin has led the design and implementation of the remote backed
storage feature in OpenSearch. This feature was introduced as
experimental in OpenSearch 2.3 and is planned for general availability
in 2.9. Some significant issues and PRs authored by Sachin for this
effort are as follows:

Feature proposal: opensearch-project#1968
Upload segments to remote store post refresh: opensearch-project#3460
Add rest endpoint for remote store restore: opensearch-project#3576
Add RemoteSegmentStoreDirectory to interact with remote segment store: opensearch-project#4020

In total, Sachin has authored 57 PRs going back to May 2022. He also
frequently reviews contributions from others and has reviewed nearly 100
PRs in the same time frame.

Signed-off-by: Andrew Ross <andrross@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants