Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] remove unnecessary empty build.gradle files #8113

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport a6b984b from #4723.

* remove unnecessary empty `build.gradle` files

these have no impact, as the targets are added by the parent
`build.gradle`. thus they do not need to exist and are currently just
cluttering the workspace and confusing people trying to work in that
area.

see also the discussion on opensearch-build#99 for some details.

Signed-off-by: Ralph Ursprung <Ralph.Ursprung@avaloq.com>

* Revert removal of distribution/docker/docker-export/build.gradle

Signed-off-by: Kartik Ganesh <gkart@amazon.com>

---------

Signed-off-by: Ralph Ursprung <Ralph.Ursprung@avaloq.com>
Signed-off-by: Kartik Ganesh <gkart@amazon.com>
Co-authored-by: Kartik Ganesh <gkart@amazon.com>
(cherry picked from commit a6b984b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testDropPrimaryDuringReplication

@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #8113 (d7bd0fe) into 2.x (59a62e7) will increase coverage by 0.06%.
The diff coverage is 84.61%.

@@             Coverage Diff              @@
##                2.x    #8113      +/-   ##
============================================
+ Coverage     70.63%   70.69%   +0.06%     
- Complexity    56771    56897     +126     
============================================
  Files          4703     4703              
  Lines        269046   269056      +10     
  Branches      39768    39770       +2     
============================================
+ Hits         190048   190220     +172     
+ Misses        62694    62539     -155     
+ Partials      16304    16297       -7     
Impacted Files Coverage Δ
.../org/opensearch/common/settings/SecureSetting.java 74.62% <84.61%> (+9.71%) ⬆️

... and 460 files with indirect coverage changes

@kartg
Copy link
Member

kartg commented Jun 16, 2023

SegmentReplicationUsingRemoteStoreIT.testDropPrimaryDuringReplication has been reported recently as a flaky test - #8059

@kartg kartg merged commit c9a10b4 into 2.x Jun 16, 2023
10 of 33 checks passed
@github-actions github-actions bot deleted the backport/backport-4723-to-2.x branch June 16, 2023 20:51
gaiksaya pushed a commit to gaiksaya/OpenSearch that referenced this pull request Jun 26, 2023
… (opensearch-project#8113)

* remove unnecessary empty `build.gradle` files

these have no impact, as the targets are added by the parent
`build.gradle`. thus they do not need to exist and are currently just
cluttering the workspace and confusing people trying to work in that
area.

see also the discussion on opensearch-build#99 for some details.



* Revert removal of distribution/docker/docker-export/build.gradle



---------




(cherry picked from commit a6b984b)

Signed-off-by: Ralph Ursprung <Ralph.Ursprung@avaloq.com>
Signed-off-by: Kartik Ganesh <gkart@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Kartik Ganesh <gkart@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant