Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Enable Point based optimization for custom comparators (#8168) #8346

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

gashutos
Copy link
Contributor

Backport 2.x of #8168

CHANGELOG.md Outdated Show resolved Hide resolved
@gashutos gashutos force-pushed the 2.x branch 2 times, most recently from b1f01d4 to 3c07fbd Compare June 29, 2023 11:59
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@reta
Copy link
Collaborator

reta commented Jun 29, 2023

This is so bad ... :( the flakiness breaks every build

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@gashutos
Copy link
Contributor Author

This is so bad ... :( the flakiness breaks every build

retriggered, lets see

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      2 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testPressureServiceStats
      2 org.opensearch.remotestore.RemoteStoreRefreshListenerIT.testRemoteRefreshRetryOnFailure
      1 org.opensearch.snapshots.RestoreSnapshotIT.testRestoreInSameRemoteStoreEnabledIndex
      1 org.opensearch.indices.replication.SegmentReplicationIT.testScrollCreatedOnReplica

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #8346 (302cb27) into 2.x (2dbe33f) will increase coverage by 0.03%.
The diff coverage is 57.28%.

@@             Coverage Diff              @@
##                2.x    #8346      +/-   ##
============================================
+ Coverage     70.54%   70.58%   +0.03%     
- Complexity    56776    56881     +105     
============================================
  Files          4706     4714       +8     
  Lines        269087   269655     +568     
  Branches      39773    39863      +90     
============================================
+ Hits         189836   190341     +505     
- Misses        62886    62950      +64     
+ Partials      16365    16364       -1     
Impacted Files Coverage Δ
...va/org/opensearch/geometry/GeometryCollection.java 96.42% <0.00%> (+0.13%) ⬆️
...in/java/org/opensearch/wildfly/model/Employee.java 0.00% <ø> (ø)
...ildfly/transport/RestHighLevelClientActivator.java 0.00% <ø> (ø)
...transport/RestHighLevelClientEmployeeResource.java 0.00% <ø> (ø)
...wildfly/transport/RestHighLevelClientProducer.java 0.00% <ø> (ø)
...ly/transport/RestHighLevelJacksonJsonProvider.java 0.00% <ø> (ø)
...apshots/restore/RestoreSnapshotRequestBuilder.java 15.00% <0.00%> (-0.79%) ⬇️
...java/org/opensearch/index/fielddata/FieldData.java 70.48% <0.00%> (-3.11%) ⬇️
.../fieldcomparator/DoubleValuesComparatorSource.java 53.33% <0.00%> (-3.34%) ⬇️
...a/fieldcomparator/FloatValuesComparatorSource.java 42.85% <0.00%> (-3.58%) ⬇️
... and 38 more

... and 455 files with indirect coverage changes

@reta reta merged commit dd49e84 into opensearch-project:2.x Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants