Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] The spotless should take care of unified imports ordering (buildSrc/ subprojects) #9314

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

reta
Copy link
Collaborator

@reta reta commented Aug 14, 2023

Description

Came out of #9082 (review), the spotless does not enforce any formatting on order of imports statements, as such those are very chaotic in the codebase.

Related Issues

Part of #9306, since there are ~3k files changed across all subprojects, sending smaller pull requests for each of the subproject.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…dSrc/ subprojects)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@opensearch-trigger-bot
Copy link
Contributor

Compatibility status:



> Task :checkCompatibility
Incompatible components: [https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/common-utils.git]
Compatible components: [https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

BUILD SUCCESSFUL in 33m 20s

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@opensearch-trigger-bot
Copy link
Contributor

Compatibility status:



> Task :checkCompatibility
Incompatible components: [https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/security-analytics.git]
Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

BUILD SUCCESSFUL in 30m 49s

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #9314 (5c4dda1) into main (8cecd5a) will increase coverage by 0.10%.
Report is 4 commits behind head on main.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #9314      +/-   ##
============================================
+ Coverage     71.10%   71.21%   +0.10%     
- Complexity    57415    57442      +27     
============================================
  Files          4775     4775              
  Lines        270700   270700              
  Branches      39566    39566              
============================================
+ Hits         192483   192770     +287     
+ Misses        62066    61670     -396     
- Partials      16151    16260     +109     
Files Changed Coverage Δ
...in/java/org/opensearch/gradle/ConcatFilesTask.java 77.77% <ø> (ø)
.../main/java/org/opensearch/gradle/EmptyDirTask.java 53.33% <ø> (ø)
...rc/main/java/org/opensearch/gradle/LoggedExec.java 0.00% <ø> (ø)
...va/org/opensearch/gradle/OpenSearchJavaPlugin.java 61.32% <ø> (ø)
...rg/opensearch/gradle/OpenSearchTestBasePlugin.java 6.38% <ø> (ø)
.../org/opensearch/gradle/docker/DockerBuildTask.java 0.00% <ø> (ø)
...opensearch/gradle/docker/DockerSupportService.java 15.57% <ø> (ø)
...rg/opensearch/gradle/http/WaitForHttpResource.java 30.10% <ø> (ø)
.../opensearch/gradle/info/GlobalBuildInfoPlugin.java 38.46% <ø> (ø)
...ensearch/gradle/internal/InternalBwcGitPlugin.java 0.00% <ø> (ø)
... and 25 more

... and 461 files with indirect coverage changes

@reta reta merged commit 4798502 into opensearch-project:main Aug 15, 2023
11 checks passed
@reta reta added the backport 2.x Backport to 2.x branch label Aug 15, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 15, 2023
…dSrc/ subprojects) (#9314)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit 4798502)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta pushed a commit that referenced this pull request Aug 15, 2023
…dSrc/ subprojects) (#9314) (#9329)

(cherry picked from commit 4798502)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kkmr pushed a commit to kkmr/OpenSearch that referenced this pull request Aug 28, 2023
…dSrc/ subprojects) (opensearch-project#9314)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Kiran Reddy <kkreddy@amazon.com>
kaushalmahi12 pushed a commit to kaushalmahi12/OpenSearch that referenced this pull request Sep 12, 2023
…dSrc/ subprojects) (opensearch-project#9314)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
brusic pushed a commit to brusic/OpenSearch that referenced this pull request Sep 25, 2023
…dSrc/ subprojects) (opensearch-project#9314)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…dSrc/ subprojects) (opensearch-project#9314)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants