Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x][Segment Replication] Support realtime reads for GET requests (#9212) #9421

Merged

Conversation

Poojita-Raj
Copy link
Contributor

@Poojita-Raj Poojita-Raj commented Aug 17, 2023

Manual backport of #9212 due to changelog conflict.

…arch-project#9212)

* route to pri shards

Signed-off-by: Poojita Raj <poojiraj@amazon.com>

* Add changelog entry

Signed-off-by: Poojita Raj <poojiraj@amazon.com>

* refactor + add multiGet support

Signed-off-by: Poojita Raj <poojiraj@amazon.com>

* address changes

Signed-off-by: Poojita Raj <poojiraj@amazon.com>

* add comment and rebase

Signed-off-by: Poojita Raj <poojiraj@amazon.com>

* address review comments

Signed-off-by: Poojita Raj <poojiraj@amazon.com>

---------

Signed-off-by: Poojita Raj <poojiraj@amazon.com>
(cherry picked from commit 914544b)
@opensearch-trigger-bot
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change d555d1d

Incompatible components

Incompatible components: [https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/ml-commons.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.search.SearchWeightedRoutingIT.testSearchAggregationWithNetworkDisruption_FailOpenEnabled

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #9421 (bfb2706) into 2.x (4cb5e66) will decrease coverage by 0.04%.
Report is 1 commits behind head on 2.x.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##                2.x    #9421      +/-   ##
============================================
- Coverage     70.82%   70.78%   -0.04%     
- Complexity    57570    57614      +44     
============================================
  Files          4762     4762              
  Lines        272058   272064       +6     
  Branches      40110    40111       +1     
============================================
- Hits         192681   192592      -89     
- Misses        62900    63009     +109     
+ Partials      16477    16463      -14     
Files Changed Coverage Δ
...opensearch/action/get/TransportMultiGetAction.java 43.63% <0.00%> (-1.65%) ⬇️
.../org/opensearch/action/get/TransportGetAction.java 66.00% <80.00%> (-1.40%) ⬇️

... and 464 files with indirect coverage changes

@Poojita-Raj
Copy link
Contributor Author

Gradle Check (Jenkins) Run Completed with:

* **RESULT:** UNSTABLE ❕

* **TEST FAILURES:**
      1 org.opensearch.search.SearchWeightedRoutingIT.testSearchAggregationWithNetworkDisruption_FailOpenEnabled
* **URL:** https://build.ci.opensearch.org/job/gradle-check/22992/

* **CommitID:** [bfb2706](https://github.com/opensearch-project/OpenSearch/commit/bfb2706616547c2a558a79255ddf7c26f2142fc7)
  Please review all [flaky tests](https://github.com/opensearch-project/OpenSearch/blob/main/DEVELOPER_GUIDE.md#flaky-tests) that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

flaky: #5957

@mch2 mch2 merged commit 2b6fa05 into opensearch-project:2.x Aug 18, 2023
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants