Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid negative scores in multi_match #9571

Closed
wants to merge 1 commit into from

Conversation

elliotvilhelm
Copy link

@elliotvilhelm elliotvilhelm commented Aug 28, 2023

Description

Prevent negative scores in multi-match queries.

Fix: #7860, by porting in changes from: elastic/elasticsearch#89016

Related Issues

Resolves #7860

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@elliotvilhelm elliotvilhelm changed the title Avoid negative scores in multi_match Signed-off-by: Elliot Pourmand <elliot@pourmand.com> Avoid negative scores in multi_match Aug 28, 2023
Signed-off-by: Elliot V Pourmand <elliot@pourmand.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 9c17ad3

Incompatible components

Incompatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/cross-cluster-replication.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@reta
Copy link
Collaborator

reta commented Aug 28, 2023

@elliotvilhelm sadly we cannot backport / copy from non-ASLv2 codebase

@dblock dblock closed this Aug 28, 2023
@dblock
Copy link
Member

dblock commented Aug 28, 2023

@elliotvilhelm I hope someone can reimplement this fix without looking at non-APLv2 code. Also maybe we/someone can turn the repro in #7860 into a REST YAML test?

@elliotvilhelm
Copy link
Author

Fix: #13829

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] function score query returned an invalid (negative) score with multi match cross fields query
3 participants