Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Telemetry-Otel] Added support for OtlpGrpcSpanExporter exporter #9666

Merged
merged 18 commits into from
Sep 21, 2023

Conversation

Shephalimittal
Copy link
Contributor

@Shephalimittal Shephalimittal commented Aug 31, 2023

Description

Added support for OtlpGrpcSpanExporter. OtelSpanExporterFactory expects exporter has method create() (For details link) OtlpGrpcSpanExporterProvider creates an instance of OtlpGrpcSpanExporter with https endpoint.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 31, 2023

Compatibility status:

Checks if related components are compatible with change afdb9b2

Incompatible components

Incompatible components: [https://github.com/opensearch-project/k-nn.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

Signed-off-by: Shephali Mittal <shephalm@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@Shephalimittal
Copy link
Contributor Author

@reta @shwetathareja @Gaganjuneja Please review.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Shephali Mittal <shephalm@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Shephali Mittal <shephalm@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Shephali Mittal <shephalm@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Shephali Mittal <shephalm@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@Shephalimittal Shephalimittal requested a review from reta September 21, 2023 16:02
@reta
Copy link
Collaborator

reta commented Sep 21, 2023

Thank you @Shephalimittal !

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteStoreStatsIT.testStatsResponseFromAllNodes

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #9666 (afdb9b2) into main (2f7969a) will increase coverage by 0.06%.
Report is 7 commits behind head on main.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #9666      +/-   ##
============================================
+ Coverage     71.10%   71.17%   +0.06%     
- Complexity    58096    58231     +135     
============================================
  Files          4825     4825              
  Lines        274101   274108       +7     
  Branches      39945    39947       +2     
============================================
+ Hits         194905   195090     +185     
+ Misses        62835    62702     -133     
+ Partials      16361    16316      -45     
Files Changed Coverage Δ
...search/telemetry/tracing/OTelResourceProvider.java 100.00% <100.00%> (ø)
...etry/tracing/exporter/OTelSpanExporterFactory.java 77.77% <100.00%> (+6.34%) ⬆️

... and 452 files with indirect coverage changes

@reta reta merged commit 3b9c005 into opensearch-project:main Sep 21, 2023
15 checks passed
@reta reta added backport 2.x Backport to 2.x branch v2.11.0 Issues and PRs related to version 2.11.0 v3.0.0 Issues and PRs related to version 3.0.0 labels Sep 21, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 21, 2023
* [Telemetry-Otel] Added support for OtlpGrpcSpanExporter exporter

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* Made endpoint settings configurable in Exporter Factory

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* Added comments

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* precommit fix

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* OTelTelemetryPluginTests test fix

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* Added test for OtlpGrpcSpanExporterProvider

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* renamed var createMethodContainsSettingsParam

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* modified endpoint comment

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* Remove configurable settings and provided support for getDefault()

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* Updated dependencies

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* Added opentelemetry-exporter-sender-okhttp dependency

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* Made opentelemetry-exporter-sender-okhttp dependency runtimeonly

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* Added license files for opentelemetry-exporter-sender-okhttp

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* Updated okhttp dependencies to runtime only

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

---------

Signed-off-by: Shephali Mittal <shephalm@amazon.com>
Signed-off-by: shephali mittal <shephali.mittal1995@gmail.com>
Co-authored-by: Shephali Mittal <shephalm@amazon.com>
(cherry picked from commit 3b9c005)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta pushed a commit that referenced this pull request Sep 21, 2023
…) (#10164)

* [Telemetry-Otel] Added support for OtlpGrpcSpanExporter exporter



* Made endpoint settings configurable in Exporter Factory



* Added comments



* precommit fix



* OTelTelemetryPluginTests test fix



* Added test for OtlpGrpcSpanExporterProvider



* renamed var createMethodContainsSettingsParam



* modified endpoint comment



* Remove configurable settings and provided support for getDefault()



* Updated dependencies



* Added opentelemetry-exporter-sender-okhttp dependency



* Made opentelemetry-exporter-sender-okhttp dependency runtimeonly



* Added license files for opentelemetry-exporter-sender-okhttp



* Updated okhttp dependencies to runtime only



---------




(cherry picked from commit 3b9c005)

Signed-off-by: Shephali Mittal <shephalm@amazon.com>
Signed-off-by: shephali mittal <shephali.mittal1995@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Shephali Mittal <shephalm@amazon.com>
brusic pushed a commit to brusic/OpenSearch that referenced this pull request Sep 25, 2023
…nsearch-project#9666)

* [Telemetry-Otel] Added support for OtlpGrpcSpanExporter exporter

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* Made endpoint settings configurable in Exporter Factory

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* Added comments

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* precommit fix

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* OTelTelemetryPluginTests test fix

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* Added test for OtlpGrpcSpanExporterProvider

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* renamed var createMethodContainsSettingsParam

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* modified endpoint comment

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* Remove configurable settings and provided support for getDefault()

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* Updated dependencies

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* Added opentelemetry-exporter-sender-okhttp dependency

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* Made opentelemetry-exporter-sender-okhttp dependency runtimeonly

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* Added license files for opentelemetry-exporter-sender-okhttp

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* Updated okhttp dependencies to runtime only

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

---------

Signed-off-by: Shephali Mittal <shephalm@amazon.com>
Signed-off-by: shephali mittal <shephali.mittal1995@gmail.com>
Co-authored-by: Shephali Mittal <shephalm@amazon.com>
Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
vikasvb90 pushed a commit to vikasvb90/OpenSearch that referenced this pull request Oct 10, 2023
…nsearch-project#9666)

* [Telemetry-Otel] Added support for OtlpGrpcSpanExporter exporter

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* Made endpoint settings configurable in Exporter Factory

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* Added comments

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* precommit fix

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* OTelTelemetryPluginTests test fix

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* Added test for OtlpGrpcSpanExporterProvider

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* renamed var createMethodContainsSettingsParam

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* modified endpoint comment

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* Remove configurable settings and provided support for getDefault()

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* Updated dependencies

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* Added opentelemetry-exporter-sender-okhttp dependency

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* Made opentelemetry-exporter-sender-okhttp dependency runtimeonly

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* Added license files for opentelemetry-exporter-sender-okhttp

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* Updated okhttp dependencies to runtime only

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

---------

Signed-off-by: Shephali Mittal <shephalm@amazon.com>
Signed-off-by: shephali mittal <shephali.mittal1995@gmail.com>
Co-authored-by: Shephali Mittal <shephalm@amazon.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…nsearch-project#9666)

* [Telemetry-Otel] Added support for OtlpGrpcSpanExporter exporter

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* Made endpoint settings configurable in Exporter Factory

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* Added comments

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* precommit fix

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* OTelTelemetryPluginTests test fix

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* Added test for OtlpGrpcSpanExporterProvider

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* renamed var createMethodContainsSettingsParam

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* modified endpoint comment

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* Remove configurable settings and provided support for getDefault()

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* Updated dependencies

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* Added opentelemetry-exporter-sender-okhttp dependency

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* Made opentelemetry-exporter-sender-okhttp dependency runtimeonly

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* Added license files for opentelemetry-exporter-sender-okhttp

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

* Updated okhttp dependencies to runtime only

Signed-off-by: Shephali Mittal <shephalm@amazon.com>

---------

Signed-off-by: Shephali Mittal <shephalm@amazon.com>
Signed-off-by: shephali mittal <shephali.mittal1995@gmail.com>
Co-authored-by: Shephali Mittal <shephalm@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch v2.11.0 Issues and PRs related to version 2.11.0 v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants