Fix ignore_missing parameter has no effect in rename ingest processor

[gaobinlong]

Description

Fix the bug of ignore_missing parameter has no effect when using template snippet in rename ingest processor, if the field in the template snippet {{field}} does not exist, the resolved field path is '', then document.hasField method will throw path cannot be null nor empty error directly even though the parameter ignore_missing is true. So we should check the resolve field path in advance, if it's empty and ignore_missing is true, exits quietly.

Related Issues

#9687

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

Compatibility status:

Checks if related components are compatible with change b19ed23

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git]

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/24318/
• CommitID: 92951f5
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/25278/
• CommitID: 7fe6edf

[codecov]

Codecov Report

Merging #9725 (b19ed23) into main (c100c0c) will decrease coverage by 0.09%.
Report is 6 commits behind head on main.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #9725      +/-   ##
============================================
- Coverage     71.16%   71.08%   -0.09%     
+ Complexity    58114    58048      -66     
============================================
  Files          4824     4824              
  Lines        273897   273900       +3     
  Branches      39910    39911       +1     
============================================
- Hits         194926   194708     -218     
- Misses        62573    62865     +292     
+ Partials      16398    16327      -71     

Files Changed	Coverage Δ
...main/java/org/opensearch/common/collect/Tuple.java	64.70% <ø> (ø)
...java/org/opensearch/common/crypto/DataKeyPair.java	0.00% <ø> (ø)
...h/common/crypto/DecryptedRangedStreamProvider.java	0.00% <ø> (ø)
...g/opensearch/compress/spi/CompressionProvider.java	100.00% <ø> (ø)
...cli/src/main/java/org/opensearch/cli/Terminal.java	74.73% <100.00%> (ø)
.../org/opensearch/ingest/common/RenameProcessor.java	97.29% <100.00%> (+0.23%)	⬆️

... and 478 files with indirect coverage changes

[gaobinlong]

Could anyone help to review this PR? Thanks!

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/25367/
• CommitID: b19ed23

[reta]

@msfroh any comments from your side? thank you!

[msfroh]

@msfroh any comments from your side? thank you!

Looks good to me! 👍 Thanks @gaobinlong !