Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Fix] Fixing Flaky Codec Tests #9889

Merged
merged 1 commit into from
Sep 7, 2023
Merged

[Bug Fix] Fixing Flaky Codec Tests #9889

merged 1 commit into from
Sep 7, 2023

Conversation

sarthakaggarwal97
Copy link
Contributor

@sarthakaggarwal97 sarthakaggarwal97 commented Sep 7, 2023 •
edited
Loading

Description

There were flaky instances where the codec was being loaded for the index, before the lock obtained to close shard was released. With this change, we will wait for the shards before proceeding for the next step.

Related Issues

Resolves #9872, #9853

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@sarthakaggarwal97 sarthakaggarwal97 changed the title fix flaky codec tests [Bug Fix] Fixing flaky codec tests Sep 7, 2023
@sarthakaggarwal97 sarthakaggarwal97 changed the title [Bug Fix] Fixing flaky codec tests [Bug Fix] Fixing Flaky Codec Tests Sep 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Compatibility status:

Checks if related components are compatible with change f594f65

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Compatibility status:

Checks if related components are compatible with change 27fbb3f

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

@sarthakaggarwal97 sarthakaggarwal97 marked this pull request as ready for review September 7, 2023 14:46
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Gradle Check (Jenkins) Run Completed with:

@sarthakaggarwal97
fix flaky codec tests
055a23a 
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Compatibility status:

Checks if related components are compatible with change 055a23a

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.cluster.routing.allocation.decider.DiskThresholdDeciderIT.testIndexCreateBlockIsRemovedWhenAnyNodesNotExceedHighWatermarkWithAutoReleaseEnabled

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #9889 (055a23a) into main (951f051) will increase coverage by 0.10%.
Report is 7 commits behind head on main.
The diff coverage is 72.22%.

@@             Coverage Diff              @@
##               main    #9889      +/-   ##
============================================
+ Coverage     71.02%   71.13%   +0.10%     
- Complexity    58040    58111      +71     
============================================
  Files          4831     4831              
  Lines        273927   273933       +6     
  Branches      39913    39915       +2     
============================================
+ Hits         194567   194862     +295     
+ Misses        63061    62755     -306     
- Partials      16299    16316      +17
Files Changed Coverage Δ
...rg/opensearch/common/settings/ClusterSettings.java 93.18% <ø> (ø)
...a/org/opensearch/index/translog/TranslogStats.java 90.27% <0.00%> (ø)
...rch/node/remotestore/RemoteStoreNodeAttribute.java 73.91% <50.00%> (-0.72%) ⬇️
...arch/gateway/remote/RemoteClusterStateService.java 83.41% <75.00%> (+4.73%) ⬆️
.../opensearch/index/engine/NRTReplicationEngine.java 78.77% <85.71%> (+1.62%) ⬆️
...search/cluster/coordination/CoordinationState.java 88.39% <100.00%> (ø)
.../java/org/opensearch/gateway/GatewayMetaState.java 70.95% <100.00%> (+2.31%) ⬆️
server/src/main/java/org/opensearch/node/Node.java 86.52% <100.00%> (+0.79%) ⬆️

... and 437 files with indirect coverage changes

@andrross andrross merged commit 731b13f into opensearch-project:main Sep 7, 2023
12 checks passed
@andrross andrross added backport 2.10 Backport to 2.10 branch backport 2.x Backport to 2.x branch labels Sep 7, 2023
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 7, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 7, 2023
@github-actions
Fix flaky codec tests (#9889)
46ea503 
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
(cherry picked from commit 731b13f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 7, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 7, 2023
@github-actions
Fix flaky codec tests (#9889)
e0cde0e 
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
(cherry picked from commit 731b13f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta pushed a commit that referenced this pull request Sep 7, 2023
@opensearch-trigger-bot @github-actions
Fix flaky codec tests (#9889) (#9896)
6bf9447 
(cherry picked from commit 731b13f)

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta pushed a commit that referenced this pull request Sep 7, 2023
@opensearch-trigger-bot @github-actions
Fix flaky codec tests (#9889) (#9897)
55aa467 
(cherry picked from commit 731b13f)

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@andrross andrross mentioned this pull request Sep 8, 2023
Closed
kaushalmahi12 pushed a commit to kaushalmahi12/OpenSearch that referenced this pull request Sep 12, 2023
@sarthakaggarwal97 @kaushalmahi12
Fix flaky codec tests (opensearch-project#9889)
663637e 
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
sarthakaggarwal97 added a commit to sarthakaggarwal97/OpenSearch that referenced this pull request Sep 20, 2023
@sarthakaggarwal97
Fix flaky codec tests (opensearch-project#9889)
9b22abb 
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
brusic pushed a commit to brusic/OpenSearch that referenced this pull request Sep 25, 2023
@sarthakaggarwal97 @brusic
Fix flaky codec tests (opensearch-project#9889)
aa3beb8 
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
@sarthakaggarwal97 @shiv0408
Fix flaky codec tests (opensearch-project#9889)
1362622 
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrross andrross andrross approved these changes

@reta reta Awaiting requested review from reta reta is a code owner

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@peternied peternied Awaiting requested review from peternied

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch backport 2.10 Backport to 2.10 branch skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Flaky test - org.opensearch.index.codec.MultiCodecMergeIT.testForceMergeMultipleCodecs
3 participants
@sarthakaggarwal97 @andrross @sachinpkale