-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump JNA from 5.5 to 5.13 #9963
Conversation
Compatibility status:Checks if related components are compatible with change 37a5dd0 Incompatible componentsIncompatible components: [https://github.com/opensearch-project/security.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git] |
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #9963 +/- ##
============================================
- Coverage 71.16% 71.15% -0.02%
+ Complexity 58114 58109 -5
============================================
Files 4824 4824
Lines 273897 273897
Branches 39910 39910
============================================
- Hits 194926 194887 -39
- Misses 62573 62664 +91
+ Partials 16398 16346 -52
|
Gradle Check (Jenkins) Run Completed with:
|
@austintlee could you please fix DCO check? thank you |
@reta it's a Github settings issue. I think it's because my primary email does not match what's in my signature.
I switched my primary email, but I think we can override this check since I do have a proper DCO in every commit? Or can you force it to re-run the check? I don't know for certain exactly how Github is picking up that old email (I did use it for my first few contributions). |
We could override DCO check when the only option, but you could amend the last commit and do force push to fix the issue. |
The problem is that that would require me to use an email that I don't want to put in the DCO. Since I corrected my email in my Github settings, do you think we can rerun the DCO check? |
Signed-off-by: Austin Lee <austin@aryn.ai> Update changelog. Signed-off-by: Austin Lee <austin@aryn.ai>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-9963-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 04f90dc3a1e859cc2caf87a223006c188a1252f4
# Push it to GitHub
git push --set-upstream origin backport/backport-9963-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
@austintlee sadly needs manual backport to |
I'm on it! |
Update changelog. Signed-off-by: Austin Lee <austin@aryn.ai> (cherry picked from commit 04f90dc)
Update changelog. Signed-off-by: Austin Lee <austin@aryn.ai> (cherry picked from commit 04f90dc)
Update changelog. Signed-off-by: Austin Lee <austin@aryn.ai> Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
Update changelog. Signed-off-by: Austin Lee <austin@aryn.ai>
Update changelog. Signed-off-by: Austin Lee <austin@aryn.ai> Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
Update changelog. Signed-off-by: Austin Lee <austin@aryn.ai>
Update changelog. Signed-off-by: Austin Lee <austin@aryn.ai> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
JNA version of 5.5 is still used causing some issues running integTest on Mac M1/2. JNA 5.7 introduced support for Mac aarch64. I see that we are already using JNA 5.13 in 'server'.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.