Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[navigation]fix: remove the workspaceAvailability field to make alert visible within workspace #1028

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

SuZhou-Joe
Copy link
Member

@SuZhou-Joe SuZhou-Joe commented Jul 30, 2024

Description

[Describe what this change achieves]

Before the fix

image

After fix

image

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@riysaxen-amzn riysaxen-amzn merged commit 0153b94 into opensearch-project:main Jul 30, 2024
10 of 13 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 30, 2024
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
(cherry picked from commit 0153b94)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.16 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting-dashboards-plugin/backport-2.16 2.16
# Navigate to the new working tree
pushd ../.worktrees/alerting-dashboards-plugin/backport-2.16
# Create a new branch
git switch --create backport-1028-to-2.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0153b94e4279e077e3b2558c14e08027faffb713
# Push it to GitHub
git push --set-upstream origin backport-1028-to-2.16
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting-dashboards-plugin/backport-2.16

Then, create a pull request where the base branch is 2.16 and the compare/head branch is backport-1028-to-2.16.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 30, 2024
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
(cherry picked from commit 0153b94)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
riysaxen-amzn pushed a commit that referenced this pull request Jul 30, 2024
(cherry picked from commit 0153b94)

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
riysaxen-amzn pushed a commit that referenced this pull request Jul 30, 2024
(cherry picked from commit 0153b94)

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants