Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failed UT of AddAlertingMonitor.test.js #1040

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Fix failed UT of AddAlertingMonitor.test.js #1040

merged 1 commit into from
Aug 1, 2024

Conversation

Hailong-am
Copy link
Contributor

@Hailong-am Hailong-am commented Aug 1, 2024 •
edited
Loading

Description

Fix failed UT of AddAlertingMonitor.test.js related to #954

Issues Resolved

#1039

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Hailong-am
fix ut
0860a74 
Signed-off-by: Hailong Cui <ihailong@amazon.com>
@Hailong-am Hailong-am mentioned this pull request Aug 1, 2024
Merged
@riysaxen-amzn riysaxen-amzn merged commit 4270710 into opensearch-project:main Aug 1, 2024
10 of 11 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 1, 2024
@github-actions
fix ut (#1040)
467dfff 
Signed-off-by: Hailong Cui <ihailong@amazon.com>
(cherry picked from commit 4270710)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Aug 1, 2024
Merged
@riysaxen-amzn riysaxen-amzn mentioned this pull request Aug 1, 2024
Closed
AWSHurneyt pushed a commit that referenced this pull request Aug 1, 2024
@opensearch-trigger-bot @github-actions
fix ut (#1040) (#1041)
9e248d1 
(cherry picked from commit 4270710)

Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riysaxen-amzn riysaxen-amzn riysaxen-amzn approved these changes

@AWSHurneyt AWSHurneyt AWSHurneyt approved these changes

@lezzago lezzago Awaiting requested review from lezzago lezzago is a code owner

@amsiglan amsiglan Awaiting requested review from amsiglan amsiglan is a code owner

@sbcd90 sbcd90 Awaiting requested review from sbcd90 sbcd90 is a code owner

@eirsep eirsep Awaiting requested review from eirsep eirsep is a code owner

@getsaurabh02 getsaurabh02 Awaiting requested review from getsaurabh02 getsaurabh02 is a code owner

@praveensameneni praveensameneni Awaiting requested review from praveensameneni praveensameneni is a code owner

@bowenlan-amzn bowenlan-amzn Awaiting requested review from bowenlan-amzn bowenlan-amzn is a code owner

@rishabhmaurya rishabhmaurya Awaiting requested review from rishabhmaurya rishabhmaurya is a code owner

Assignees
No one assigned
Labels
backport 2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hailong-am @riysaxen-amzn @AWSHurneyt