Updated all pages with new header UI #1056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
amsiglan
requested review from
lezzago,
AWSHurneyt,
sbcd90,
eirsep,
getsaurabh02,
praveensameneni,
bowenlan-amzn,
rishabhmaurya and
riysaxen-amzn
as code owners
public/pages/Dashboard/components/DashboardEmptyPrompt/DashboardEmptyPrompt.js
Show resolved
Hide resolved
|
can we upload the video with new UX? Also, let's monitor E2E for this PR, I remember e2e was failing for earlier PRs for this plugin |
Looks like there's a compile error in the alerting backend artifiact. @amsiglan could you paste the result of running the tests locally? If that passes, I think we can merge this PR while waiting for the alerting backend compiler issue to be fixed. |
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
|
Passing screenshots for the failures seen in the CI 
|
…edundant code; updated tests Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
AWSHurneyt
approved these changes
Aug 20, 2024
riysaxen-amzn
approved these changes
Aug 20, 2024
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting-dashboards-plugin/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/alerting-dashboards-plugin/backport-2.x
# Create a new branch
git switch --create backport-1056-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 db4af39b4af10d25e8f691795a95eb1191ce1354
# Push it to GitHub
git push --set-upstream origin backport-1056-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting-dashboards-plugin/backport-2.xThen, create a pull request where the |
amsiglan
added a commit
to amsiglan/alerting-dashboards-plugin
that referenced
this pull request
Aug 20, 2024
* updated all pages with new header UI Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * fixed UTs Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * fixed cross cluster API; cypress workflow Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * fixed data source logic on page load for view/edit monitor; removed redundant code; updated tests Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
5 tasks
AWSHurneyt
pushed a commit
that referenced
this pull request
Aug 21, 2024
* updated all pages with new header UI * fixed UTs * fixed cross cluster API; cypress workflow * fixed data source logic on page load for view/edit monitor; removed redundant code; updated tests --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
SuZhou-Joe
reviewed
Aug 24, 2024
Comment on lines
+150
to
+153
| core.chrome.navGroup.addNavLinksToGroup( | ||
| DEFAULT_NAV_GROUPS['security-analytics'], | ||
| navLinks | ||
| ); |
There was a problem hiding this comment.
Alerting is not supposed to be added to security-analytics, can we raise a PR to revert?
AWSHurneyt
pushed a commit
to AWSHurneyt/alerting-dashboards-plugin
that referenced
this pull request
Sep 19, 2024
* updated all pages with new header UI Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * fixed UTs Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * fixed cross cluster API; cypress workflow Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * fixed data source logic on page load for view/edit monitor; removed redundant code; updated tests Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the header for each page to match the new core experience
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.