-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Side nav mds #1063
Side nav mds #1063
Conversation
Signed-off-by: Riya Saxena <riysaxen@amazon.com>
Signed-off-by: Riya Saxena <riysaxen@amazon.com>
Signed-off-by: Riya Saxena <riysaxen@amazon.com>
UTs passing locally:
|
Signed-off-by: Riya Saxena <riysaxen@amazon.com>
Signed-off-by: Riya <69919272+riysaxen-amzn@users.noreply.github.com>
a2d07a7
e2e cypress tests are failing because Alerting backend is not backported fully it seems ->
This is due to Core made some changes to the abstract query builder that is causing this error: opensearch-project/OpenSearch#15328. But 2.x should be working as the change is not backported |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting-dashboards-plugin/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/alerting-dashboards-plugin/backport-2.x
# Create a new branch
git switch --create backport-1063-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5feef220ca9ab9532d67ac5d85e1edc3c67c31d9
# Push it to GitHub
git push --set-upstream origin backport-1063-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting-dashboards-plugin/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting-dashboards-plugin/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/alerting-dashboards-plugin/backport-2.17
# Create a new branch
git switch --create backport-1063-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5feef220ca9ab9532d67ac5d85e1edc3c67c31d9
# Push it to GitHub
git push --set-upstream origin backport-1063-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting-dashboards-plugin/backport-2.17 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting-dashboards-plugin/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/alerting-dashboards-plugin/backport-2.x
# Create a new branch
git switch --create backport-1063-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5feef220ca9ab9532d67ac5d85e1edc3c67c31d9
# Push it to GitHub
git push --set-upstream origin backport-1063-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting-dashboards-plugin/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting-dashboards-plugin/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/alerting-dashboards-plugin/backport-2.17
# Create a new branch
git switch --create backport-1063-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5feef220ca9ab9532d67ac5d85e1edc3c67c31d9
# Push it to GitHub
git push --set-upstream origin backport-1063-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting-dashboards-plugin/backport-2.17 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting-dashboards-plugin/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/alerting-dashboards-plugin/backport-2.x
# Create a new branch
git switch --create backport-1063-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5feef220ca9ab9532d67ac5d85e1edc3c67c31d9
# Push it to GitHub
git push --set-upstream origin backport-1063-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting-dashboards-plugin/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting-dashboards-plugin/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/alerting-dashboards-plugin/backport-2.17
# Create a new branch
git switch --create backport-1063-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5feef220ca9ab9532d67ac5d85e1edc3c67c31d9
# Push it to GitHub
git push --set-upstream origin backport-1063-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting-dashboards-plugin/backport-2.17 Then, create a pull request where the |
* persist dataSource when swictching between sideNav Signed-off-by: Riya Saxena <riysaxen@amazon.com> * persist dataSource when swictching between sideNav Signed-off-by: Riya Saxena <riysaxen@amazon.com> * persist dataSource when swictching between sideNav Signed-off-by: Riya Saxena <riysaxen@amazon.com> * fix the CI Signed-off-by: Riya Saxena <riysaxen@amazon.com> --------- Signed-off-by: Riya Saxena <riysaxen@amazon.com> Signed-off-by: Riya <69919272+riysaxen-amzn@users.noreply.github.com> (cherry picked from commit 5feef22)
* persist dataSource when swictching between sideNav Signed-off-by: Riya Saxena <riysaxen@amazon.com> * persist dataSource when swictching between sideNav Signed-off-by: Riya Saxena <riysaxen@amazon.com> * persist dataSource when swictching between sideNav Signed-off-by: Riya Saxena <riysaxen@amazon.com> * fix the CI Signed-off-by: Riya Saxena <riysaxen@amazon.com> --------- Signed-off-by: Riya Saxena <riysaxen@amazon.com> Signed-off-by: Riya <69919272+riysaxen-amzn@users.noreply.github.com> (cherry picked from commit 5feef22)
* persist dataSource when swictching between sideNav Signed-off-by: Riya Saxena <riysaxen@amazon.com> * persist dataSource when swictching between sideNav Signed-off-by: Riya Saxena <riysaxen@amazon.com> * persist dataSource when swictching between sideNav Signed-off-by: Riya Saxena <riysaxen@amazon.com> * fix the CI Signed-off-by: Riya Saxena <riysaxen@amazon.com> --------- Signed-off-by: Riya Saxena <riysaxen@amazon.com> Signed-off-by: Riya <69919272+riysaxen-amzn@users.noreply.github.com> (cherry picked from commit 5feef22)
* persist dataSource when swictching between sideNav Signed-off-by: Riya Saxena <riysaxen@amazon.com> * persist dataSource when swictching between sideNav Signed-off-by: Riya Saxena <riysaxen@amazon.com> * persist dataSource when swictching between sideNav Signed-off-by: Riya Saxena <riysaxen@amazon.com> * fix the CI Signed-off-by: Riya Saxena <riysaxen@amazon.com> --------- Signed-off-by: Riya Saxena <riysaxen@amazon.com> Signed-off-by: Riya <69919272+riysaxen-amzn@users.noreply.github.com> (cherry picked from commit 5feef22)
* persist dataSource when swictching between sideNav Signed-off-by: Riya Saxena <riysaxen@amazon.com> * persist dataSource when swictching between sideNav Signed-off-by: Riya Saxena <riysaxen@amazon.com> * persist dataSource when swictching between sideNav Signed-off-by: Riya Saxena <riysaxen@amazon.com> * fix the CI Signed-off-by: Riya Saxena <riysaxen@amazon.com> --------- Signed-off-by: Riya Saxena <riysaxen@amazon.com> Signed-off-by: Riya <69919272+riysaxen-amzn@users.noreply.github.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Description
This PR persists dataSourceId across applications under new Nav change
Issues Resolved
alertingMDS.mov
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.