Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove last updated backported to 2.5 #810

Open
wants to merge 3 commits into
base: 2.5
Choose a base branch
from

Conversation

kohinoor98
Copy link

Description

Removed "last updated by" sections from the UI as the SearchMonitor API is no longer intended to return that info. See the issue below for more details.

I have backported for 2.5

Issues Resolved

#763

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: kohinoor98 <kohinoorchatterjee1998@gmail.com>
Signed-off-by: kohinoor98 <kohinoorchatterjee1998@gmail.com>
@AWSHurneyt
Copy link
Collaborator

Manual backport of PR #767

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9c78b44) 52.75% compared to head (54e2435) 52.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##              2.5     #810      +/-   ##
==========================================
+ Coverage   52.75%   52.76%   +0.01%     
==========================================
  Files         210      210              
  Lines        5480     5477       -3     
  Branches      768      766       -2     
==========================================
- Hits         2891     2890       -1     
+ Misses       2587     2585       -2     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kohinoor98
Copy link
Author

Hi @AWSHurneyt

The E2E tests are failing. I think they are failing because cluster_metrics_monitor_spec.js is missing an import sample_cluster_metrics_monitor and monitors_dashboard_spec.js is accessing an element that does not exist in the DOM, probably due to some delay in loading the application. I think this could be a flaky issue.

Please guide me on the next steps.

Thanks,
KC

* Removed "last updated by" section from the UI as the SearchMonitor API can no longer return that info.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Updated cypress workflow.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

---------

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
(cherry picked from commit 1bea77f)
Signed-off-by: kohinoor98 <kohinoorchatterjee1998@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants