Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.5] Removed "last updated by" sections from the UI. (#767) #902

Merged

Conversation

AWSHurneyt
Copy link
Collaborator

Description

Manual backport of PR #767

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* Removed "last updated by" section from the UI as the SearchMonitor API can no longer return that info.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Updated cypress workflow.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

---------

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

(cherry picked from commit 1bea77f)
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.76%. Comparing base (9c78b44) to head (45fc010).

Additional details and impacted files
@@            Coverage Diff             @@
##              2.5     #902      +/-   ##
==========================================
+ Coverage   52.75%   52.76%   +0.01%     
==========================================
  Files         210      210              
  Lines        5480     5477       -3     
  Branches      768      766       -2     
==========================================
- Hits         2891     2890       -1     
+ Misses       2587     2585       -2     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
@AWSHurneyt
Copy link
Collaborator Author

AWSHurneyt commented Mar 15, 2024

Investigated the monitors_dashboard_spec.js failures more. Checked out the commit most recent commit to the 2.5 branch (9c78b44bd48ec1913046a76baee95a7928632081), and ran the tests locally; they're also failing at that commit point with the following error.

[2024-03-15T21:32:12,832][ERROR][o.o.a.u.AlertingException] [integTest-0] Alerting error: Failed to execute phase [query], all shards failed; shardFailures {[jzOkp_ddTwialmOpZ8Fk0Q][.opendistro-alerting-config][0]: RemoteTransportException[[integTest-0][127.0.0.1:9300][indices:data/read/search[phase/query]]]; nested: QueryShardException[No mapping found for [start_time] in order to sort on]; }

The monitors_dashboard_spec.js failures appear to be unrelated to the changes in this PR. Will investigate, and resolve those in a separate PR.

@AWSHurneyt AWSHurneyt merged commit 3da8f33 into opensearch-project:2.5 Mar 15, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants