-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug fix for duplicate notification channels #981
bug fix for duplicate notification channels #981
Conversation
Signed-off-by: Riya Saxena <riysaxen@amazon.com>
Signed-off-by: Riya Saxena <riysaxen@amazon.com>
738295f
into
opensearch-project:main
* bug fix for duplicate notification channels Signed-off-by: Riya Saxena <riysaxen@amazon.com> * bug fix for UI dropdown Signed-off-by: Riya Saxena <riysaxen@amazon.com> --------- Signed-off-by: Riya Saxena <riysaxen@amazon.com> (cherry picked from commit 738295f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* bug fix for duplicate notification channels Signed-off-by: Riya Saxena <riysaxen@amazon.com> * bug fix for UI dropdown Signed-off-by: Riya Saxena <riysaxen@amazon.com> --------- Signed-off-by: Riya Saxena <riysaxen@amazon.com> (cherry picked from commit 738295f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* bug fix for duplicate notification channels Signed-off-by: Riya Saxena <riysaxen@amazon.com> * bug fix for UI dropdown Signed-off-by: Riya Saxena <riysaxen@amazon.com> --------- Signed-off-by: Riya Saxena <riysaxen@amazon.com> (cherry picked from commit 738295f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* bug fix for duplicate notification channels Signed-off-by: Riya Saxena <riysaxen@amazon.com> * bug fix for UI dropdown Signed-off-by: Riya Saxena <riysaxen@amazon.com> --------- Signed-off-by: Riya Saxena <riysaxen@amazon.com> (cherry picked from commit 738295f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* bug fix for duplicate notification channels Signed-off-by: Riya Saxena <riysaxen@amazon.com> * bug fix for UI dropdown Signed-off-by: Riya Saxena <riysaxen@amazon.com> --------- Signed-off-by: Riya Saxena <riysaxen@amazon.com> (cherry picked from commit 738295f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* bug fix for duplicate notification channels Signed-off-by: Riya Saxena <riysaxen@amazon.com> * bug fix for UI dropdown Signed-off-by: Riya Saxena <riysaxen@amazon.com> --------- Signed-off-by: Riya Saxena <riysaxen@amazon.com> (cherry picked from commit 738295f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* bug fix for duplicate notification channels * bug fix for UI dropdown --------- (cherry picked from commit 738295f) Signed-off-by: Riya Saxena <riysaxen@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting-dashboards-plugin/backport-2.11 2.11
# Navigate to the new working tree
pushd ../.worktrees/alerting-dashboards-plugin/backport-2.11
# Create a new branch
git switch --create backport-981-to-2.11
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 738295f12c9fc1564f43941574eece8d3cebcfeb
# Push it to GitHub
git push --set-upstream origin backport-981-to-2.11
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting-dashboards-plugin/backport-2.11 Then, create a pull request where the |
* bug fix for duplicate notification channels Signed-off-by: Riya Saxena <riysaxen@amazon.com> * bug fix for UI dropdown Signed-off-by: Riya Saxena <riysaxen@amazon.com> --------- Signed-off-by: Riya Saxena <riysaxen@amazon.com> (cherry picked from commit 738295f)
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting-dashboards-plugin/backport-2.13 2.13
# Navigate to the new working tree
pushd ../.worktrees/alerting-dashboards-plugin/backport-2.13
# Create a new branch
git switch --create backport-981-to-2.13
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 738295f12c9fc1564f43941574eece8d3cebcfeb
# Push it to GitHub
git push --set-upstream origin backport-981-to-2.13
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting-dashboards-plugin/backport-2.13 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting-dashboards-plugin/backport-2.14 2.14
# Navigate to the new working tree
pushd ../.worktrees/alerting-dashboards-plugin/backport-2.14
# Create a new branch
git switch --create backport-981-to-2.14
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 738295f12c9fc1564f43941574eece8d3cebcfeb
# Push it to GitHub
git push --set-upstream origin backport-981-to-2.14
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting-dashboards-plugin/backport-2.14 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting-dashboards-plugin/backport-2.12 2.12
# Navigate to the new working tree
pushd ../.worktrees/alerting-dashboards-plugin/backport-2.12
# Create a new branch
git switch --create backport-981-to-2.12
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 738295f12c9fc1564f43941574eece8d3cebcfeb
# Push it to GitHub
git push --set-upstream origin backport-981-to-2.12
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting-dashboards-plugin/backport-2.12 Then, create a pull request where the |
* bug fix for duplicate notification channels Signed-off-by: Riya Saxena <riysaxen@amazon.com> * bug fix for UI dropdown Signed-off-by: Riya Saxena <riysaxen@amazon.com> --------- Signed-off-by: Riya Saxena <riysaxen@amazon.com> (cherry picked from commit 738295f)
* bug fix for duplicate notification channels Signed-off-by: Riya Saxena <riysaxen@amazon.com> * bug fix for UI dropdown Signed-off-by: Riya Saxena <riysaxen@amazon.com> --------- Signed-off-by: Riya Saxena <riysaxen@amazon.com> (cherry picked from commit 738295f)
* bug fix for duplicate notification channels Signed-off-by: Riya Saxena <riysaxen@amazon.com> * bug fix for UI dropdown Signed-off-by: Riya Saxena <riysaxen@amazon.com> --------- Signed-off-by: Riya Saxena <riysaxen@amazon.com> (cherry picked from commit 738295f)
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting-dashboards-plugin/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/alerting-dashboards-plugin/backport-2.x
# Create a new branch
git switch --create backport-981-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 738295f12c9fc1564f43941574eece8d3cebcfeb
# Push it to GitHub
git push --set-upstream origin backport-981-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting-dashboards-plugin/backport-2.x Then, create a pull request where the |
* bug fix for duplicate notification channels Signed-off-by: Riya Saxena <riysaxen@amazon.com> * bug fix for UI dropdown Signed-off-by: Riya Saxena <riysaxen@amazon.com> --------- Signed-off-by: Riya Saxena <riysaxen@amazon.com> (cherry picked from commit 738295f)
* bug fix for duplicate notification channels Signed-off-by: Riya Saxena <riysaxen@amazon.com> * bug fix for UI dropdown Signed-off-by: Riya Saxena <riysaxen@amazon.com> --------- Signed-off-by: Riya Saxena <riysaxen@amazon.com> (cherry picked from commit 738295f)
…1046) * bug fix for duplicate notification channels (#981) * bug fix for duplicate notification channels Signed-off-by: Riya Saxena <riysaxen@amazon.com> * bug fix for UI dropdown Signed-off-by: Riya Saxena <riysaxen@amazon.com> --------- Signed-off-by: Riya Saxena <riysaxen@amazon.com> (cherry picked from commit 738295f) * updated lock file Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Description
Notification Channels list shows objects multiple times while configuring a trigger when creating a monitor. This PR will fix that issue
Issues Resolved
#795
Tests
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.